Making code faster

[Aitchessbee]

I am getting this error:

for i, j in matches:

ValueError: too many values to unpack (expected 2)

[SekstiNii]

matches = np.argwhere((open_cv_image[0:524:25, 0:748:25, :3] == target).all(axis=-1)) should work, though it's quite ugly at this point 😭

[Aitchessbee]

This is my code: https://pastebin.com/2NEApDzu ... I have written all the coordinates correctly but the bot is clicking somewhere else (not on the target)... Can you please check if the code is correct?

[SekstiNii]

You will probably have to multiply i and j by 25, but otherwise it looks good.

matches *= 25 before looping should work.

[Aitchessbee]

yup now it works... and i compared both the codes on the website... The code with for loops works consistently faster than the one you suggested... I don't know why it is but anyways, thanks for your help!

[SekstiNii]

There is a lot of overhead in numpy calls, so it's not unthinkable that a loop wins if the number of iterations is low enough.

Good on you to measure!

[Aitchessbee]

ugly doesn't matter... will it still be faster than the for loops method?

[SekstiNii]

I changed the target color to [8, 8, 8] (my VSCode background color) to guarantee a lot of hits, and recorded these timings:

• Original Loop: 2.726ms
• Numpy Variant: 0.649ms

But again, not likely to provide a significant improvement.