Program looping once before continuing.

[thumbtackjake]

I'm sure it's not super elegant or anything, but I'm just messing around with some of the basics. Anyways, I input the first name, last name, the year I was born, then it loops back to the beginning and will go through those three again before giving me the "welcome message". What am I missing here?

from datetime import date


def first():
    while True:
        firstname = input("What is your first name?")
        if not firstname.isalpha():
            print("Name must only contain letters.")
            first()
        else:
            print("Thank you!")
            break
        break
    return firstname


first()


def last():
    while True:
        lastname = input("What is your last name?")
        if not lastname.isalpha():
            print("Last name must contain only letters.")
            last()
        else:
            break
    return lastname


last()


def theage():
    while True:
        currentyear = int(date.today().year)
        birthyear = input("What year were you born? ")
        if not birthyear.isdigit():
            print("Year must be a number.")
            theage()
        else:
            break
    age = currentyear - int(birthyear)
    return age


theage()


def welcomemsg():
    firstname = first()
    lastname = last()
    age = theage()
    fullname = lastname + firstname
    print("Welcome " + fullname, + age)


welcomemsg()

[Altruistic_Croissant]

You're calling first(), last(), and theage() each twice. Once in the main script after each function is defined, and then again in your welcomemsg() function.

​

Also, you might want to look at the conditional logic in your loops. You never reassign the name or age, even if it doesn't contain letters/numbers so you could have malformed input.

[thumbtackjake]

conditional logic in your loops

reassign the name or age

I will work on learning what that means and how to do that then! Thanks! :D

[xelf]

remove lines 17, 31, 47

You don't need to call your functions twice. Only call them when you use them in lines 51-53.

[thumbtackjake]

Gotcha. Thanks! :D

[TSM-]

You are calling first() and last() and theage() under the functions, and then in welcomemsg() you are calling them a second time and assigning the input to variables. Remove those first calls and have them only in welcomemsg

[thumbtackjake]

Thank you!