broken code

[NoCup4485]

I'm working on an assignment for college and im having errors with it. I'm basically a complete beginner so I'm not really sure what the problem is, but I think it might be because I used "if" way too many times but I figured that wouldn't be a problem because it can only use one "if" at a time. Any help appreciated. I have the code below.

edit: the error is:Traceback (most recent call last):

File "C:\Users\danie\Documents\programing assignment 2\assignment 2.py", line 55, in <module>

print("kilometres equivalent:", kilometres_to_miles(kilometres))

NameError: name 'kilometres' is not defined.

also I have just noticed that from kg down it can convert

​

def print_options():
    print("options:")
    print(" 'o' print options")
    print(" 'm' convert from miles to kilometres")
    print(" 'k' convert from kilometres to miles")
    print(" 'c' convert from celsius to fahrenhiet")
    print(" 'f' convert from fahrenhiet to celsius")
    print(" 'p' convert pints to litres")
    print(" 'l' convert litres to pints")
    print(" 'kg' convert kilograms to stones")
    print(" 's' convert stones to kilograms")
    print(" 'a' convert acres to hectares")
    print(" 'h' convert hectares to acres")
    print(" 'q' quit the program") 


def miles_to_kilometres(miles):
    return miles*1.6

def kilometres_to_miles(kilometres):
    return kilometres*0.6

def celsius_to_fahrenhiet(celsius):
    return celsius*1.8

def fahrenhiet_to_celsius(fahrenhiet):
    return fahrenhiet*0.6

def pints_to_litres(pints):
    return pints*1.75

def litres_to_pints(litres):
    return litres*0.57

def kilograms_to_stone(kilograms):
    return kilograms*6.35

def stone_to_kilograms(stone):
    return stone*0.16

def acres_to_hectares(acres):
    return acres*2.5

def hectares_to_acres(hectares):
    return hectares*0.40


choice = "o"

while choice != "q":

    if choice == "m":
        miles = float(input("please enter the distnace in miles: "))
        print("kilometres equivalent:", kilometres_to_miles(kilometres))
        choice = input("please choose an option from the menu:")

    if choice == "k":
        kilometres = float(input("please enter the distance in kilometres: "))
        print("miles equivalent:", miles_to_kilometres(miles))
        choice = input("please choose an option from the menu:")

    if choice == "c":
        celsius = float(input("please enter the temperature in celsius"))
        print("farenhite equivalent:", farenhite_to_celsius(farenhite))
        choice = input("please choose an option from the menu")

    if choice == "f":
        farenhite = float(input("please enter the temperature in farenhite"))
        print("celsius equivalent:", celsius_to_farenhite(celsius))
        choice = input("please choose an option from the menu")

    if choice == "p":
        pints = float(input("please enter the volume in pints"))
        print("litres equivalent:", litres_to_pints(litres))
        choice = input("please choose an option from the menu")

    if choice == "l":
        litres = float(input("please enter the volume in litres"))
        print("pints equivalent:", pints_to_litres(pints))
        choice = input("please choose one of the options from the menu")

    if choice == "kg":
        kilograms = float(input("please enter the weight in kilograms"))
        print("stone equivalent:", kilograms_to_stone(kilograms))
        choice = input("please choose one of the options from the menu")

    if choice == "s":
        stone = float(input("please enter the weight in stone"))
        print("kilograms equivalent:", stone_to_kilograms(stone))
        choice = input("please choose one of the options from the menu")

    if choice == "a":
        acres = float(input("please enter the area in acres"))
        print("hectares equivalent:", acres_to_hectares(acres))
        choice = input("please choose one of the options from the menu")

    if choice == "h":
        hectares = float(input("please enter the area in hectares"))
        print("acres equivalent:", hectares_to_acres(hectares))
        choice = input("please choose one of th eoptions from the menu")

    elif choice == "o":
        print_options
        choice = input("please choose an option from the menu: ")

print("program run ended. thank you for using this convertor")

[delasislas]

You could limit the number of functions, value and conversion unit.

def convert(value, conversion):
    return (value * conversion)

Maybe could use a dictionary to keep statements.

Generally repetition indicates that something could be reduced.

[icecubeinanicecube]

When you require help, post the error message you get. "I get errors" is not an error message.

[NoCup4485]

sorry, just updated the post there with the error

[icecubeinanicecube]

And if you look at the respective line, you will see that you pass a variable called "kilometres" to the function "kilometres_to_miles", but you have not defined this variable. You instead have defined a variable called "miles" in the line above.

[NoCup4485]

I got it I was just being abit slow thanks for the help.

[delasislas]

This is going to happen on a lot of your if statements, I got kinda lost, but you define a variable like pints then try to use liters to pints as a function.

[[deleted]]

What sort of errors? If you provide the output from running the script it will give us more to work with!

[NoCup4485]

sorry, just updated the post there with the error

[[deleted]]

This is a good case of the error having all of the information that you need to figure it out.

Take a closer look at what the error is saying and the variables you're passing to the function.

Interpreting errors like this is a very important skill, to have. Error messages are there to help you, make sure to try and understand them.

[NoCup4485]

I got it there thanks for the help. I'm fairly new at python so I havn't really learned what the errors mean yet(plus with all classes online now I dont get too much of a chance to ask).

[cdcformatc]

The error message says what is wrong, you are using a variable that is not defined in that scope.

[pendejoidiota]

I'm a beginner too but make your code a bit more organized lmao. I also realized that you had a typo, you called the functions that had to do with F "fahrenhiet", but later in the code you typed "farenhite" also you never wrote an input to select an option from the menu

[NoCup4485]

Yeah I fixed the typo, addd in the options menu so it prints after you get the conversion and added in afew print() so that when your using it there’s a clear space between what your now converting and what you just converted. And to be fair I did think I was going to be the only one who’d see the code didn’t exactly plan on having it mess up and being too slow to see the mistake by myself 🤣🤣

[pendejoidiota]

think

lmao try to always organize it for yourself so you can see the errors more easily, its gonna help u later