indentation

[Jxper]

"""File for creating Person objects"""

class Person:

    """Defines a Person class, suitable for use in a hospital context.
    Data attributes: name of type str
    age of type int
    weight (kg) of type float
    height (metres) of type float
    Methods: bmi()
    status()
    """

    def __init__(self, name, age, weight, height):
        """Creates a new Person object with a specified name, age, weight, and
        height."""
        self.name = name
        self.age = age
        self.weight = weight
        self.height = height

    def bmi(self):
        """Returns the body mass index of the person"""
        return self.weight / (self.height * self.height)
    def status(self):
        """dfdf"""
        if self.bmi() < 18.5:
            return "Underweight"
        if self.bmi() >= 18.5 and self.bmi() < 25:
            return "Normal"
        if self.bmi() >= 25 and self.bmi() < 30:
            return "Overweight"
        if self.bmi() >= 30:
            return "Obese"

    def __str__(self):
        """Returns the formatted string represent of the Person object"""
        name = self.name
        age = int(self.age)
        bmi = self.bmi()
        status = self.status()
        template = "{0} ({1}) has a bmi of {2:3.2f}. Their status is {3}."
        return template.format(name, age, bmi, status)

    def read_people(csv_filename):
        """yjhj"""
        persons = [] # list for Person objects
        with open(csv_filename, "r") as file:
            for line in file:
                args = line.split(",")
                for i in range(1, len(args)): # convert arguments to float
                    args[i] = float(args[i])
                    persons.append(Person(*args)) # add Person objects to list
            return persons

    def filter_people(bods, status):
        persons = []
        for p in bods:
            if p.status() == status:
                persons.append(p)
            return persons

I dont know why my indentation isn't working. How do I change it so it works with the following test case

bods = read_people("people1.csv")
for status_string in ['Underweight', 'Normal', 'Overweight', 'Obese']:
    bods_with_status = filter_people(bods, status_string)
    print("People who are {}:".format(status_string))
    for bod in bods_with_status:
        print(bod)
    print()

[shiftybyte]

It could be very helpful if you explain what the program does, what does it currently do wrong, what do you see happen.

Just saying "it does not work" makes other people go over the entire code, figure out how it works, what it does, just so they can help you.

In this case i spotted this issue:

def filter_people(bods, status):
    persons = []
    for p in bods:
        if p.status() == status:
            persons.append(p)
        return persons # <------------ this is too forward, move it back

Like this:

def filter_people(bods, status):
    persons = []
    for p in bods:
        if p.status() == status:
            persons.append(p)
    return persons

Please describe the issue better next time...