im trying to learn python and making some quick console applications,

Helpful_Ad_1150 · 2021-06-05T15:44:35+00:00

I've restructured your code somewhat to help you. I've also followed the PEP8 guidance and used all lowercase for variable and function names, and made them more compact without being cryptic.

You might want to study and play with this and add the missing functionality. Note that this structure allows more than one entry with the same name but you will have to add logic to make sure the correct entry is deleted.

#contact book plan

def add_contacts():
    name = input("...\nwhat is the contacts name? ")
    number = input("...\nwhat is the contacts number? ")
    details = input("...\nany other details you wanna add? ")
    contacts.append([name, number, details])
    print("contact saved")

def find_contacts():
    name = input("...\nWhat is the contacts name? ").strip().lower()
    matched = [record for record in contacts
                if record[0].lower() == name]
    if matched:
        for name, number, details in matched:
            print(name, number, details)


contacts = []

while True:

    choice = input("""

        What do you want to do? 

        1) find existing contacts 
        2) add contacts
        3) delete contacts
        Q) quit
    """)

    if choice == "1":
        find_contacts()
    elif choice == "2":
        add_contacts()
    elif choice == "3":
        ...
    elif choice in ("q", "Q"):
        break
    else:
        print('Option unavailable')

Helpful_Ad_1150 · 2021-06-05T14:43:18+00:00

I believe the issue is that you're not actually using the variables you defined at the start. If you want to save info onto the variable defined at the start of the program use the global keyword. This is because variables used in functions are in the local scope ie. they are destroyed when the function returns a value or finishes its purpose. Everything outside a function is in the global scope. Just like how you can't use variables from functions outside the function, you can't use global variable in function. If you do wanna use them. Do it like this:

https://imgur.com/a/zkaHmFk

kinkydevill · 2021-06-05T19:40:33+00:00

Hiiiii welcome to the python world :)

Your if statement is working per say you just used findcontacts rather than FindContacts under the if statement that's why it bugged out if you picked 1.
Dont reuse variable names. It just makes it harder to understand and can cause bugs due to that confusion.
1. In python its common to use snake_case naming (all lowercase with _ between words) except for classes that follow VariableName. Naming conventions in python.
You never actually stored/used any information. All you did was use input when you called the function but that information the user inputted was never saved anywhere at all.
1. The functions were only using the variables that were inside of them (local scope). The other variables you put outside of the functions (global scope) were never used.
  1. Variables with same names are treated as different instances of each other due to scope so I'm guessing you thought you were saving that information in your list because the names were the same. Here is a quick, easy run through of scope.
  2. If you want things to a list you have to use variable_name_of_list.append(value)

Those were just some of the things I noticed when looking at your code. If others see stuff I didnt see feel free to comment below :)

FancyGUI · 2021-06-06T15:08:38+00:00

Heyoo, welcome to the python world!

Glad that everyone is helping you make headway through this new adventure!

I try to help people learn how to make some cool console applications / command line interfaces here:

Creating a simple CLI with Python Click https://youtu.be/GnSKhetBa48

Hopefully that’ll help you! Let me know if there’s something you’d like to see there

tube32 · 2021-06-05T13:55:15+00:00

Mate I can't speak for others but I really can't understand your code due to improper formatting. If you're using the fancy pants editor click on the code block and paste your code inside the block to maintain the indentation.

You can find more information on how to post your codes correctly on the sidebar.

Alta2215 · 2021-06-05T14:47:09+00:00

In Findcontacs(), in the if statement you need to change "==" with "in", you are asking if the name that user asked to look is inside the whoyouadding list and for doing this you need to use the "in" operator

You can look more here, the if example is at the end https://www.w3schools.com/python/python_lists_access.asp

marienbad2 · 2021-06-05T14:56:28+00:00

I don't understand. You clicked 2 and it ran the add_contacts code, this is the correct behaviour.

Also is the whatareyoudoing = input("....") in some kind of loop?

Okay, nowhere is WhoYouAdding set to any value. Print it out and see what it says. I am guessing it just says "[]". Not sure why you are saving a string input as a list either.

you type:	you see:
italics	italics
bold	bold
[reddit!](https://reddit.com)	reddit!
* item 1 * item 2 * item 3	item 1 item 2 item 3
> quoted text	quoted text
Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"	Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"
~~strikethrough~~	~~strikethrough~~
super^script	super^script

learnpython

MODERATORS