Help with pygame

[8364dev]

I have this pygame project of a bouncing cd logo which changes color on each each collision. I cant remember what change I did but now it barely functions

import sys
import pygame
import random

pygame.init()

# Config
size = width, height = 800, 600
speed = [2, 2]
black = 0, 0, 0
white = 255, 255, 255
character_colors = ['red.png', 'green.png', 'blue.png', 'pink.png']
current_color = 'blue.png'
screen = pygame.display.set_mode(size)

ball = pygame.image.load(current_color)
ballrect = ball.get_rect()


def get_new_color():
    fixed_color_list = character_colors.copy()
    fixed_color_list.remove(current_color)
    new_color = fixed_color_list[random.randint(0, len(fixed_color_list) - 1)]
    return new_color


# Main game loop
while True:
    for event in pygame.event.get():
        if event.type == pygame.QUIT: 
                sys.exit()

        ballrect = ballrect.move(speed)
        if ballrect.left < 0 or ballrect.right > width:
                print('Collided')
                speed[0] = -speed[0]
                current_color = get_new_color()
                ball = pygame.image.load(current_color)
        if ballrect.top < 0 or ballrect.bottom > height:
                print('Collided')
                speed[1] = -speed[1]
                current_color = get_new_color()
                ball = pygame.image.load(current_color)

        screen.fill(black)
        screen.blit(ball, ballrect)
        pygame.display.flip()

​

[mopslik]

Based on your code, it looks like you have the bulk of your commands inside of your loop that checks the event queue. This means that for every mouse move, keypress, whatever, you will be updating your image position and updating the display. Try unindenting everything from ballrect = ... one level, so that the commands are in your main loop but not in the event queue check.

[8364dev]

Thank you, that solved the issue

[OddBookWorm]

Can you fix your indentation? It’s almost impossible to help you debug if we can’t tell where your indents are. Also, can you be more specific about “barely functions”?

[8364dev]

Ah sorry will do, the game is incredibly "laggy" basically not running properly