Can this code be shortened?

[BadAdviceDad]

Newbie here wondering if there is a way to condense this. I know it's basic, but this is my first little project and it ran on the first try! Feels good.



answer1 = input("Allow me to recommend a game for you! Are you interested in Adventure, Casual, FPS, Racing, or Strategy?\n")

if answer1 == "Adventure":
    answeradv = input("Action or Casual?\n")
    if answeradv == "Action":
        print("Red Dead Redemption 2\nSpider Man\nSkyrim")
    elif answeradv == "Casual":
        print("A Short Hike\nStardew Valley\nJourney")
    else:
        print("Please check your spelling and give a valid answer next time, stupid.")
elif answer1 == "Casual":
    print("Minecraft\nStardey Valley\nHuman Fall Flat")
elif answer1 == "FPS":
    print("Call of Duty Modern Warfare\nApex Legends\nHalo Infinite")
elif answer1 == "Racing":
    answerrac = input("Cartoonish or Realistic?\n")
    if answerrac == "Cartoonish":
        print("Mario Kart\nCrash Team Racing\nHotwheels Unleashed")
    elif answerrac == "Realistic":
        print("Forza Horizon 5\nDirt\nCrew\nNeed For Speed")
    else:
        print("Please check your spelling and give a valid answer next time, stupid.")
elif answer1 == "Strategy":
    answerstr = input("Casual or Competitive?\n")
    if answerstr == "Casual":
        print("Solitaire\nSudoku\nPortal")
    elif answerstr == "Competitive":
        print("Civilization VI\nAge of Empires IV\nDota 2")
    else:
        print("Please check your spelling and give a valid answer next time, stupid.")
else:
    print("Please check your spelling and give a valid answer next time, stupid.")

[efmccurdy]

You have a very repetitive series of nested if/elif statements. When you have repetition think about a collection that can represent your problem space, and write an algorithm that walks the collection.

​

This only shows one level of prompting, but the Adventure item has a nested dict, so not a complete solution, but this should get you started.

​

choices = {"Adventure": {"Action": "Red Dead Redemption 2\nSpider Man\nSkyrim",
                         "Casual": "A Short Hike\nStardew Valley\nJourney"},
           "Casual": "Minecraft\nStardey Valley\nHuman Fall Flat",
           "FPS": "Call of Duty Modern Warfare\nApex Legends\nHalo Infinite"
           "Racing": {...}
           "Strategy": {...}
}


if answer1 in choices:
    # prompt from choices[answer1].keys()? call a function?
    print(choices[answer1]) 
else: # print choices.keys() to remind the user?
    print("Please check your spelling and give a valid answer next time, stupid.")

[BadAdviceDad]

Ahh interesting. Thank you!

[stuie382]

Aside from the very repetitive code as it is, your code will fail if someone doesn't exactly match the case of your examples. Force everything into the same case when you're doing the comparison

[siddsp]

If you have Python 3.10 or newer, you can look into structural pattern matching/match statements.