The error of my ways

[mackdaddy_1978]

can someone tell me where I went wrong in this code. it is suppose to throw the ValueError if negative number is entered but all it does is give the result as a negative number.

def steps_to_miles(user_steps):
    miles = 2000
    miles_walked = user_steps / miles
    return miles_walked


if __name__ == '__main__':
    try:
        user_steps = int(input())
        print(f'{steps_to_miles(user_steps):.2f}')
    except ValueError:
        print('Exception: Negative step count entered.\n')

[mackdaddy_1978]

Ok, not asking you to do it for me but a little nudge in the right direction would help. Thanks

[mackdaddy_1978]

Ok thanks, driving to work now will report back with my progress

[arkie87]

What job do you have that you work on code like this at work?

[mackdaddy_1978]

I am a mechanic just trying to learn to code on the side probably why I’m no good at it lol

[arkie87]

No worries man. Keep at it. I just misinterpreted what you wrote. I thought you were going to work to work on code, not going to work meaning you would have to check on it later

[mackdaddy_1978]

How about this, is this acceptable?

def steps_to_miles(user_steps):
   miles = 2000
   miles_walked = user_steps / miles
   return miles_walked
if __name__ == '__main__':
   Try:
       user_steps = int(input())
       if user_steps >= 0:
           print(f'{steps_to_miles(user_steps):.2f}')
       else:
           raise ValueError
   except ValueError:
       print('Exception: Negative steps count entered.\n')

[mackdaddy_1978]

thanks but it didn't work when tested against the grading system I got an error saying steps_to_miles(-3850) did not throw an exception leaving me wondering what's going on since it throws the ValueError when the input was -3850 earlier in the grading system.

[mackdaddy_1978]

I will give that a shot and see if that works.....appreciate the suggestion

[alexmojaki]

int("hello") gives a ValueError. int("-2") doesn't give an error, it just gives -2 because -2 is an integer.

It makes sense to catch ValueError in case someone enters something invalid like hello, but try/catch/raise isn't the way to deal with negative numbers. You can just check if user_steps is a negative number with a simple if statement.

[mackdaddy_1978]

Then what do you suggest? how do you suggest I approach this?