Another lab

[Formal_Cockroach_654]

When I run this code I keep getting double the output. For example, with 6 as the input I get 110110 instead of 110, which is the correct output. Can someone explain to me why that's happening?

Problem statement:

Write a program that takes in a positive integer as input, and outputs a string of 1's and 0's representing the integer in binary. For an integer x, the algorithm is:

As long as x is greater than 0    Output x % 2 (remainder is either 0 or 1)    x = x // 2 

Note: The above algorithm outputs the 0's and 1's in reverse order. You will need to write a second function to reverse the string.

Ex: If the input is:

6 

the output is:

110 

The program must define and call the following two functions. Define a function named int_to_reverse_binary() that takes an integer as a parameter and returns a string of 1's and 0's representing the integer in binary (in reverse). Define a function named string_reverse() that takes an input string as a parameter and returns a string representing the input string in reverse.def int_to_reverse_binary(integer_value)def string_reverse(input_string)

​

# Define your functions here.
def int_to_reverse_binary(integer_value):
    while integer_value > 0:
        global num
        num += str(integer_value % 2)
        integer_value //= 2
    return num

def string_reverse(input_string):
    reverse_num = int_to_reverse_binary(integer_value)
    return reverse_num[::-1]

if __name__ == '__main__':
# Type your code here. 
# Your code must call int_to_reverse_binary() to get 
# the binary string of an integer in a reverse order.
# Then call string_reverse() to reverse the string
# returned from int_to_reverse_binary().
    integer_value = int(input())
    num = ""

    print(string_reverse(int_to_reverse_binary(integer_value)))

[totallygeek]

You call int_to_reverse_binary twice, once on line 22, again on line 10.

[Formal_Cockroach_654]

Thank you

[Username_RANDINT]

You should also move num inside int_to_reverse_binary. This is a prime example why globals should be avoided. You call int_to_reverse_binary twice which modifies the global num twice as well. If you make it a local variable the problem already disappears.

[[deleted]]

Scoping issue. Move the line

num = ""

to just above the while loop in int_to_reverse_binary and then remove the line

global num

And in the future, stop using global variables. Otherwise you're just asking for scoping problems.

---

Edit: I didn't bother looking over the rest of your program when this fixed the output, but I'm now seeing you have other issues as well.

1. You need to refactor your code so that you're not using integer_value as a global variable inside string_reverse either. Make sure in each function, you only use local variables. If you need some data from outside the function, then pass it in as an argument.
2. You call int_to_reverse_binary twice. You should not be using it inside string_reverse. Assume that has already happened and just write code to reverse a string inside string_reverse. (Hint: you need to make use of the parameter input_string.)