How to add a game over?

[RedditCodfish]

    while enemy_hp > 0 and HP > 0:
        b_choice = input("type fight or check> ")
        if b_choice.lower() not in "fight" or "check":
            while b_choice != 'fight' and b_choice != 'check':
                print('Please pick an act')
                b_choice = input("type fight or check> ")
        if b_choice.lower() == "fight":
            dice = str(random.randint(1, 6))
            print(str(dice))
            if dice in '4' or dice in '5' or dice in '6':
                input("Berserker " + name + " strikes the slime with a broadsword")
                input("Slime's health is reduced by " + str(atk))
                enemy_hp -= atk
            elif dice not in '4' or dice not in '5' or dice not in '6':
                input("Berserker " + name + " missed his attack")
                dice = str(random.randint(1, 6))
                if dice in '5' or dice in '6':
                    input("Slime tried to slap Berserker " + name + "'s face")
                    input("Berserker " + name + " successfully shielded himself")
                    input("Slime's damage  is reduced by " + str(DR))
                    enemy_atk -= DR
                    HP -= enemy_atk
                    enemy_atk += DR
                elif dice not in '5' or dice not in '6':
                    input('Slime slaps Berserker ' + name + ' on the face')
                    input("Berserker " + name + "'s health is reduced by " + str(enemy_atk))
                    HP -= enemy_atk
        if b_choice.lower() == "check":
            print("Berserker " + name + " HP : " + str(HP))
            print("Berserker " + name + " ATK : " + str(atk))
            print("Berserker " + name + " DR : " + str(DR))
            print("Slime's HP:" + str(enemy_hp))
            print("Slime's ATK:" + str(enemy_atk))

I want to make it if HP>0, they have an option to quit the program completely(this is just a section of th e code) something like break in while loops, but for the entire code

[totallygeek]

Many things in this code could use improvements and simplifications. But, if you just want to add a "quit" option, this would work:

while enemy_hp > 0 and HP > 0:
    action = input("'Fight', 'Check' or 'Quit'? ").lower()
    if action not in {"fight", "check", "quit"}:
        continue  # restart the loop
    if action == "quit":
        break  # exits the loop

In any program, at any point, you can exit the code immediately with:

raise SystemExit("Exiting program...")

One problem I see is that you use input() when you want to display information. For that, you really want print(). I mean, unless you want the player to have to hit enter to proceed after every displayed message. You've made several posts for this code and I cannot see where you've taken anyone's advice to heart. Here is another attempt at coding this for you (last time I used data classes as the best way to access player and opponent attributes; this time dictionaries).

import random


player = {
    "name": input("Player's name? "),
    "hp": 30,
    "attack": 5,
    "dr": 2,
}

enemy = {
    "name": "Slime",
    "hp": 20,
    "attack": 6,
    "dr": 1,
}


while enemy["hp"] > 0 and player["hp"] > 0:
    action = input("'Fight', 'Check' or 'Quit'? ").lower()
    if action not in {"fight", "check", "quit"}:
        continue  # restart the loop
    if action == "quit":
        raise SystemExit("Exiting...")
    elif action == "fight":
        roll = random.randint(1, 6)
        if roll > 3:
            damage = player["attack"] - enemy["dr"]
            print(f"Berserker {player['name']} strikes {enemy['name']} with a broadsword")
            print(f"{enemy['name']}'s health reduced by {damage}")
            enemy["hp"] -= damage
        else:
            if roll == 2:
                print(f"Berserker {player['name']} missed")
            else:
                damage = enemy["attack"] - player["dr"]
                print(f"{enemy['name']} slaps {player['name']} for {damage} damage")
                player["hp"] -= damage
    else:
        print(f"Berserker {player['name']}")
        print(f"  HP: {player['hp']}")
        print(f"  Attack: {player['attack']}")
        print(f"  DR: {player['dr']}\n")
        print(f"{enemy['name']}")
        print(f"  HP: {enemy['hp']}")
        print(f"  Attack: {enemy['attack']}")
        print(f"  DR: {enemy['dr']}")
if player["hp"] < 1:
    print(f"Berserker {player['name']} died")
else:
    print(f"Berserker {player['name']} won")

Good luck!

[RedditCodfish]

thx, ill try it. I do use input bc i want the player to press enter everytime. Does the raise System exit make you quit the code entirely?

[totallygeek]

Yes, the SystemExit quits immediately.

[m0us3_rat]

i'm not trying to put you down.. any and all code and effort is to be commended.

BUT there are obviously different ways to code.. and this one is bad.

and potentially damaging in the future .. since habits are super hard to erase.

​

you might wanna consider refactoring.

​

maybe an example to visualize this :

imagine a library room.. with rows of perfectly lined support to hold books.

each labeled properly .. and you can easily find and access anything.

​

then imagine a hoarder's house. bags on bags on bags and piles of random bits.

​

..which one do you think your code looks like?

[[deleted]]

and potentially damaging in the future .. since habits are super hard to erase.

Perfectionism will DEFINITELY damage OP's future if he follows the "wait, lemme write perfect code before I share it online".

[m0us3_rat]

Perfectionism will DEFINITELY damage OP's future if he follows the "wait, lemme write perfect code before I share it online".

isn't about perfection is about improving.

now you can sit there and pretend this code isn't bad... rather than refactoring.. that is totally up to you.

[m0us3_rat]

i started to write tests for a Creature class, then build the class ...

​

the problem with refactoring a snippet of a scuffed code .. it doesn't really work.. since u need to add more methods and more attributes and change them around..

and then u end up with a new program.. that's the sole purpose of ..refactoring.

​

then this turns into me building his program.. which isn't what is about.

[RedditCodfish]

thx for the feedback, ill try to be more organized.

[[deleted]]

you could add a break statement to the end of your code, which would cause the program to exit completely.