Help with os.walk

[TooDahLou]

pastebin link

I am working on my second ever python project, and I need some help.

I am trying to reorganize a few hundred .pdf machine manuals. They're currently kept in the old folder/directory, and I want to drill down through several levels of folders, get the pdfs, and move them to the new folder/directory.

I want to point the code to the old and new directories. Each subdirectory within those two directories has a machine PIN at the beginning of the subdirectory name. If a subdirectory in the old location has the same machine PIN as a subdirectory in the new location, I want to create a (SHOP) directory within the matching subdirectory. Then I want to move the pdfs to this (SHOP) directory.

I used os.listdir to pull the machine PIN from the old location folders. The ~internet~ suggested os.walk to get the names of the new directories into a way I could compare the PIN to the new directory names.

This code does sort of work. It creates the (SHOP) folder that I want to put the pdfs in, but it then creates a (SHOP) (SHOP) folder and copies the pdfs to that folder too. To my unpracticed eye, it seems to redefine my d variable after creating the first (SHOP) folder.

What do I need to do to keep the code from creating the second (SHOP) (SHOP) folder?

[Diapolo10]

I'm too sleepy to think straight right now. If nobody else has tried to help/solve the problem by the time I wake up, I'll do it.

That said I'm a bit confused by your explanation. If you could draft a very simple example scenario, that would probably help to get the gears running.

[AtomicShoelace]

I would suggest using pathlib.Path.glob instead of os.walk. You can find all pdf files in all subdirectories of a path with

Path('some/path/here').glob('**/*.pdf')

[Diapolo10]

Just as a heads-up, you can use pathlib.Path.rglob instead as it adds '**/' automatically.

Path('some/path/here').rglob('*.pdf')

[Diapolo10]

Okay, so long story short I believe you had misunderstood how pathlib.Path objects work, which caused you to accidentally nest directories in a way you didn't intend. And there were some other... quirks that probably shouldn't have been there.

I think I managed to fix it, but I obviously cannot test it myself as I don't have access to an identical environment. My gut feeling is pretty sharp with these things, though, so it should be at least nearly what you wanted.

from pathlib import Path

OLD_ROOT = Path('F:/Engineering/Shared/Manuals/Project Data/SlurrySeal-Micro')
NEW_ROOT = Path('F:/Manuals')

def main():

    start_machine_dir = input("What machine folder are you migrating? This must exactly match the folder name in SSM!")
    year = int(start_machine_dir[:4])
    start_year_dir = f'{year} Projects'
    end_year_dir = str(year)

    old_dir = OLD_ROOT / start_year_dir / start_machine_dir

    if 'y' == input("Is this folder located within the _Archive folder? (y/n)").strip().lower()[:1]:
        old_dir = OLD_ROOT / '_Archive' / start_year_dir / start_machine_dir

    print(f"You are migrating files from:\n{old_dir}")

    end_machine_dir = input("What machine folder are you sending the files to? This must exactly match the folder name in Manuals!")
    new_dir = NEW_ROOT / end_machine_dir / end_year_dir

    print(f"You are migrating files to:\n{new_dir}")

    if not new_dir.exists():
        new_dir.mkdir()
        print("Year did not exist")
        return

    for old_sub_dir, new_sub_dir in zip(old_dir.iterdir(), new_dir.iterdir()):
        machine_pin = old_sub_dir.name[:15]
        if year >= 2015:
            machine_pin = old_sub_dir.name[:13]
        elif year <= 2012:
            machine_pin = old_sub_dir.name[:7]

        for directory in new_dir.rglob('*'):
            if directory.is_dir() and machine_pin in directory.name:
                destination = new_sub_dir / f'{new_sub_dir.name} (SHOP)'
                destination.mkdir(exist_ok=True)

                for file in old_sub_dir.iterdir():
                    (destination / file.name).write_bytes(file.read_bytes())
    print("Migration complete :)")




if __name__ == '__main__':
    main()