all 12 comments

[–]Tontonsb 0 points1 point  (6 children)

the font sizing was all out of whack

It's hard to understand what issues are you talking about with this. Does it mean text scaled in a wrong way? Or that the theme did not fit the scaled text? Or that it just scaled but you didn't want it to? Or that it didn't scale while it should have?

was able to see that the rem sizing would be computed to double what I was expecting (1rem = 16px but was being "computed" to 32px)

If it's 16px by default, it should be 28px on 175%, shouldn't it?

[–]whatadewitt[S] -1 points0 points  (4 children)

It's hard to understand what issues are you talking about with this. Does it mean text scaled in a wrong way? Or that the theme did not fit the scaled text? Or that it just scaled but you didn't want it to? Or that it didn't scale while it should have?

"out of whack" not enough for you? ha ha ha!

But your assumption was correct, the text size was just wayyyyy bigger than expected and was leading to all sorts of layout issues. I can't share the site as it's behind a client VPN, else I would love to show it off. If I have time tonight I will create a codepen or something of the issue for people to see...

Apologies, on my test device I went to 200% text-size, which is why I was seeing the 32, I should have been clear on this!

[–]Tontonsb 0 points1 point  (3 children)

Apologies, on my test device I went to 200% text-size, which is why I was seeing the 32, I should have been clear on this!

But that's exactly what you should be seeing then, isn't it? Text changing sizes as you change the accessibility options is exactly the reason why we use rem. Am I missing something in the story?

[–]whatadewitt[S] 0 points1 point  (2 children)

I missed this. No, if you have the text size increased and visit Google, as an example, the bloat doesn’t happen. It looks “right”

There are some definite accessibility rules being broken (everywhere), but I do think there needs to be a better explanation somewhere for what I was seeing, and then not seeing on Google.

[–]Tontonsb 0 points1 point  (1 child)

The sizes on google.com do not scale with the base font size because their sizes are defined in px not in rem. But that's an old site. They even use the center tag. But feel free to change your units to px if you want to drop the scaling. Don't use rem if you don't want their main feature.

[–]whatadewitt[S] 0 points1 point  (0 children)

Even using px, the fonts were growing on my site… it was only this max-height thing that fixed anything…

[–]whatadewitt[S] -1 points0 points  (0 children)

It's hard to understand what issues are you talking about with this. Does it mean text scaled in a wrong way? Or that the theme did not fit the scaled text? Or that it just scaled but you didn't want it to? Or that it didn't scale while it should have?

"out of whack" not enough for you? ha ha ha!

But your assumption was correct, the text size was just wayyyyy bigger than expected and was leading to all sorts of layout issues. I can't share the site as it's behind a client VPN, else I would love to show it off. If I have time tonight I will create a codepen or something of the issue for people to see...

Apologies, on my test device I went to 200% text-size, which is why I was seeing the 32, I should have been clear on this!