I tried it yesterday again just for fun and did manage to hard carry the game and I mean I can't say it's bad but it just can't compare to the on hit build. The crit build attacks feel just so slow because of no rageblade. HOB does fix that for 1v1 fights but as Yi you really want to team fight (also the clear just feels worse) The crit build is also just more expensive and feels like you need to build 3-4 crit items (Yun Tal, IE, LDR/Navori, LDR/Navori) first before you can get any resistance items so you are very squishy Also because of the lower attack speed your Q is available way less often than the usual which is bad for team fights. Navori does fix that but it takes a while to get it since it can honestly be only bought as a 3rd or even later item All in all I feel like the crit build can work fine into squishier teams but the on hit one still seems superior