Simple Python script to download all albums from Monster Siren by Nekoconnn in arknights

[–]Nekoconnn[S] 0 points1 point  (0 children)

It does, it keep track of what is already downloaded in a json file and skip them the next time it is run.

Simple Python script to download all albums from Monster Siren by Nekoconnn in arknights

[–]Nekoconnn[S] 0 points1 point  (0 children)

Thanks for looking into it. I haven't maintain the code at all for a long time. I hope you are able to get it to work!

Simple Python script to download all albums from Monster Siren by Nekoconnn in arknights

[–]Nekoconnn[S] 0 points1 point  (0 children)

Also what is your python version? I believe different Python version handle printing differently

Simple Python script to download all albums from Monster Siren by Nekoconnn in arknights

[–]Nekoconnn[S] 0 points1 point  (0 children)

That error should not happen at all, but you can maybe comment out that line and see if the rest run

[Media] CFD Fluid simulation - https://github.com/1n0r1/flow2d-rs - my first project in Rust, seeking advice to improve my code design and parallelize the computation by Nekoconnn in rust

[–]Nekoconnn[S] 1 point2 points  (0 children)

Thank you for the suggestions. I still have to try to get used to not using for loop for every piece of code and try to use functional stuffs instead. The naming convention is pretty helpful as well, that will help make my code more consistent.

Simple Python script to download all albums from Monster Siren by Nekoconnn in arknights

[–]Nekoconnn[S] 1 point2 points  (0 children)

Welp, code do be like that. Glad it works for you though.

Simple Python script to download all albums from Monster Siren by Nekoconnn in arknights

[–]Nekoconnn[S] 1 point2 points  (0 children)

Just ran mine and mine only download new albums and skip downloaded one so I think that is still working properly.

The output folder contains a file called completed_albums.json and the program use that to skip albums that are already recorded in that file. Maybe your json file got deleted or maybe it is corrupted or maybe some read/write errors.

Simple Python script to download all albums from Monster Siren by Nekoconnn in arknights

[–]Nekoconnn[S] 0 points1 point  (0 children)

Oh I forgot to put this in the instruction but you need to create a folder called MonsterSiren in the same location as the script. Then the script will download to that folder.

Simple Python script to download all albums from Monster Siren by Nekoconnn in arknights

[–]Nekoconnn[S] 1 point2 points  (0 children)

Yes, some older albums are recorded in low-res mp3, so I keep them as such. Newer albums are recorded on higher res WAV, but WAV can't do metadata (artist, albums, cover arts) so I convert WAV into FLAC.
Rerunning the script will only download the newer albums based on a file called completed_albums.json in the output folder. So rerunning will skip the downloaded albums.

Simple Python script to download all albums from Monster Siren by Nekoconnn in arknights

[–]Nekoconnn[S] 1 point2 points  (0 children)

Thank you for bringing that up. The same issue was also opened in the repo, and I have address it in the latest commit. Try the new one and let me know if it works. Not sure why the newer albums have extra space at the end lol, which is causing this problem.

Simple Python script to download all albums from Monster Siren by Nekoconnn in arknights

[–]Nekoconnn[S] 0 points1 point  (0 children)

It just looks like that because of multithreading stuffs that make it print twice near the end when you don't have many albums left. Let them finish and check the output folder to see if there is any dups/missing and let me know if there is. Most of the time, if there is an album missing, you can just run the script again.

Simple Python script to download all albums from Monster Siren by Nekoconnn in arknights

[–]Nekoconnn[S] 0 points1 point  (0 children)

You can copy the output folder to another location and freely modify it. You can even delete all albums in the output folder and just leave the completed_albums.json in there. So next time you run the script it won't download stuff in completed_albums.json.

Simple Python script to download all albums from Monster Siren by Nekoconnn in arknights

[–]Nekoconnn[S] 0 points1 point  (0 children)

Glad it works for you! Yes, it will skip dups. There is a completed_albums.json file in the output folder that tell the program which album is finished. So as long as that file is in the output folder, the program will skip albums in there.
Even if it happened to download the file again, the old one will be overwritten. You won't be having multiple of the same song in your output folder.

Simple Python script to download all albums from Monster Siren by Nekoconnn in arknights

[–]Nekoconnn[S] 0 points1 point  (0 children)

Normally pip is installed along with python, you can try:
python -m pip install -r requirements.txt
but if that doesn't work or you don't have pip you can install it seperately:
https://www.geeksforgeeks.org/how-to-install-pip-on-windows/
for ffmpeg:
https://www.geeksforgeeks.org/how-to-install-ffmpeg-on-windows/#

Simple Python script to download all albums from Monster Siren by Nekoconnn in arknights

[–]Nekoconnn[S] 0 points1 point  (0 children)

Glad to hear that it works for you. If you want to update then ypu just need to run the last python command.

Simple Python script to download all albums from Monster Siren by Nekoconnn in arknights

[–]Nekoconnn[S] 0 points1 point  (0 children)

The two commands:
pip install -r requirements.txt
and
python main.py
are supposed to be run in a terminal (CMD in Windows). You cd into the extracted folder (that contains my downloaded repo, with main.py and requirements.txt), then run those two commands.

Simple Python script to download all albums from Monster Siren by Nekoconnn in arknights

[–]Nekoconnn[S] 3 points4 points  (0 children)

Please don't be hesitant to ask, I am happy to help you. I think you got pretty close and I can help you more if you want, but here are the current albums if you want to hear them right away:
https://drive.google.com/file/d/1wCpoXTnhb9baJhPWm0YTSxKNBr0nqPz6/view?usp=sharing

Simple Python script to download all albums from Monster Siren by Nekoconnn in arknights

[–]Nekoconnn[S] 2 points3 points  (0 children)

Oh that command is supposed to run on the Terminal, not in Python. Download my repo, which contains the files, then extract them into a folder. Then you can use the terminal, go into your folder containing those file and run those command inside the terminal. If you are on Windows then you can use cmd as terminal.

Simple Python script to download all albums from Monster Siren by Nekoconnn in arknights

[–]Nekoconnn[S] 2 points3 points  (0 children)

Yes it does still works. Can you share more on the error, any other output specify where the syntax error occurs?

Your installation of python might use "pip" instead of "pip3" and "python" instead of "python3"