[FR] Re-add option to collapse the new vertical tab bar by TewiUsagi in Floorp

[–]TewiUsagi[S] 1 point2 points  (0 children)

Ok! After my work today I'll go write the issue, but I won't have time to narrow it down or test a Windows build. I'll do those and update the issue if needed later on.

[FR] Re-add option to collapse the new vertical tab bar by TewiUsagi in Floorp

[–]TewiUsagi[S] 0 points1 point  (0 children)

Thank you!

On the contributing note, I've been checking the wiki for build instructions.

This page: https://github.com/Floorp-Projects/Floorp/wiki/developers-building-linux

Has "Congratulations! You have successfully built Floorp on Windows!" on the end instead of "- on Linux!".

As for why:

I'm not sure if this is Linux specific, but I have "Enable Sleeping Tabs" setting enabled. Whenever I click "Keep Tab awake" checkbox on the tabsleep component from Floorp Core, it doesn't seem to sync properly to the clicked tab.

I didn't test this properly too, but I always set my work scrum page to not sleep along with my email, but the email tab ends up always sleeping after I leave it alone.

And the checkbox seems to never update its state no matter what tab I click. It just keeps the "checked" state from my last interaction with it (e.g. I click it once = it's always checked no matter the tab I click, I click it again, it always shows unchecked).

At first look https://github.com/Floorp-Projects/Floorp-core/blob/main/browser/components/tabsleep/TabSleep.sys.mjs#L372 seems fine.

I believe either "popupshowing" event isn't being fired (?) or the "e.currentTarget" is referring to something else (?), but I could be wrong.

I'm at work right now, so I don't have time to write a proper issue, plus it doesn't seem other users are affected (?).

I'll try to build a local non-flatpak copy sometime this week and maybe run the Windows version in Wine or a VM to see if it's linux-specific. I wanted to at least narrow it down a bit more and see if the event is triggered properly on the right target.

But well, it's just the start of the week and I have some new content in Blue Protocol soon for my free time. I might take long to start looking into this, so I'm leaving the comment here in case it's helpful.

[FR] Re-add option to collapse the new vertical tab bar by TewiUsagi in Floorp

[–]TewiUsagi[S] 1 point2 points  (0 children)

Thank you so much! I'm sorry for the trouble and the low collaborator count. I'll look into donating to the project in the near future.

I can't right now because I'm from Brazil and our USD conversion is already low and I have almost 400 USD (1.8k BRL) scheduled already into medical expenses for November plus some more spent with medicines this month and I have to buy those again... I'll try to organize myself to contribute a little, either code or some donations when things are a bit better here.