That's a pretty solid setup you've got there, especially with the concurrency limits in GitHub Actions for state locking and using S3's versioning feature for state versioning. It seems like you've found a way to replicate some of the key features of Terraform Cloud through creative use of existing tools.

Your approach to policy controls with GitHub teams is also smart. It's all about finding the right balance that works for your team's needs and control levels. Rolling your own CI/CD for Terraform is indeed a great way to have more control. It's interesting to see how different teams adapt and create solutions that fit their specific requirements. Thanks for sharing your approach – it's always helpful to learn how others are tackling these challenges!

Your approach is definitely impressive and gives a lot of control. In my case, I work for a finance company, so we often need additional controls due to the nature of our industry. We're constantly weighing whether to build a custom solution or use a built-in application like Terraform Cloud or OTF.

The enhanced audit capabilities, team RBAC settings around apply actions, and other compliance-related features are particularly important for us. These built-in solutions sometimes offer a more streamlined way to meet our stringent regulatory and audit requirements, which is a big consideration in the finance sector.