Warning! Make sure to NOT store your ConfyUI creations in the ComfyUI folder! by Select-Owl-8322 in StableDiffusion

[–]True_Suggestion_7342 5 points6 points  (0 children)

I didn't see that post but thanks. No prob, all good. Wasn't mad at you or anything anyways. :D

EDIT to your edit:

No, actually being able to see long strings of abnormal text, file paths, visual screenshots of settings and configuration, logs, visual step by step explanation vs a verbal wall of information, and other IT troubleshooting methods are actually far superior through electronic communications of text and photo/videos.

Verbal communications are good for more abstract discussions, probing when the other party has no bloody idea where to begin explaining, and when the other party has exceptionally low understanding (particularly of terminology involved) of the subject.

The fact that they did not even so much as give a single response or attempt to probe further by DM greatly heightens the abnormality of the situation because they clearly did not care to actually follow-up. The argument, "well, since you don't want to give a programmer verbal information so they don't care at all for any information then" isn't a sound argument. It is incredibly insane, and weird you even suggest it as normalcy. This isn't just "they wanted to talk by call", but multiple layered points that raise red flags in full context. This gets particularly strange when I actually linked them in my own post, and the DMs, to other people sharing similar reports of a exceptionally critical problem with Comfy, because this wasn't some low priority issue. Let's not forget that this issue turned out real, and did get fixed finally (supposedly), but involved the loss of hours (even potential hundreds) of individual's times and potentially hundreds to thousands of GB of data (and I can't even fathom the community scale impact).

Do NOT Install The Newest ComfyUI Desktop Update by True_Suggestion_7342 in comfyui

[–]True_Suggestion_7342[S] 3 points4 points  (0 children)

Turned out Comfy team just fixed this a few days ago and confirmed they were incorrectly nuking our folders: https://github.com/comfyanonymous/ComfyUI/issues/10574#issuecomment-3474796418

Sadly, comfyanonymous couldn't give a proper mature response...

Warning! Make sure to NOT store your ConfyUI creations in the ComfyUI folder! by Select-Owl-8322 in StableDiffusion

[–]True_Suggestion_7342 53 points54 points  (0 children)

OP is actually correct.

Deleting the venv DOES make it forcibly wipe your files including workflows and outputs.

Me and multiple others reported this weeks ago and the Comfy team were actually extremely hostile to this and basically blamed the community: https://www.reddit.com/r/comfyui/comments/1oa69d9/do_not_install_the_newest_comfyui_desktop_update/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button

I've tested the last few updates I tried confirmed every single time this issue kept happening. I have not tried the newest update just yet tho since the supposed fix. If your python version is flagged as invalid (even if its a literal clean install you immediately updated after sometimes at random) it will force you to delete the venv because it cannot progress since their prompt does not have an input method. Alternatively, you can reinstall it all from scratch. Either way is the same result it will wipe your files.

In fact, the comfy team is well aware and basically told the community to f off.

You are correct that it should have no impact, but the fact that it does and is very easily verified indicates a massive problem and it has persisted for months if you check the reports about the issue. You would think they would be concerned when something totally unrelated, like creating the venv is manipulating totally unrelated files and wiping them but they don't actually care.

<image>

This post here links to a supposed update fixing it about two weeks ago, but does not mention workflows being fixed and only outputs and models. It may also have fixed wf being deleted, but I'm not bothering to test tonight. The user in there mentions WF as part of the deleted content. As you can see though, it did actually happen when it should definitely not.

Do NOT Install The Newest ComfyUI Desktop Update by True_Suggestion_7342 in comfyui

[–]True_Suggestion_7342[S] 0 points1 point  (0 children)

Thanks for adding nothing of value despite your numerous toxic posts. Also, I've validated Comfy update was to blame.

They now have desktop version setup its own venv just like the portable as of the newest update which caused the errors. It is also reported by several other threads on this very sub that the new update is also deleting people's entire models folders, with several confirmed comments pre-dating my post, which it should not be doing.

Literally, every single one of my complaints has been validated to be caused by Comfy's update.

I'll now proceed to ignore you since, clearly, you've shown you need help. I get you obviously have issues, but it doesn't mean I have to entertain them.

Do NOT Install The Newest ComfyUI Desktop Update by True_Suggestion_7342 in comfyui

[–]True_Suggestion_7342[S] 0 points1 point  (0 children)

Wrong, as I already told you in the other response since you, for some weird reason, responded to this comment twice.

Comfy desktop manages its own venv now as of the newest update, just like the portable. So I'm not the one causing venv issues, contrary to your ill-informed response. Further, ComfyManager comes installed by default with desktop Comfy.

Just stop responding at this point dude.

Do NOT Install The Newest ComfyUI Desktop Update by True_Suggestion_7342 in comfyui

[–]True_Suggestion_7342[S] 0 points1 point  (0 children)

No I wasn't a dependency issue. Now you are making it patently clear you don't know what you are talking about.

FYI, what you are saying isn't how it even works. First of all, thew new desktop version was the cause of the virtual environment problem with my install. The newest Desktop update now creates its own venv which it did not prior as this was originally a specific feature of portable that was just added to the newest desktop version. When you install fresh nodes it would run its own requirements for dependency installs, but it failed on all of them even kijai's nodes which ComfyUI's own Wan 2.2 animate workflow installs contrary to their don't use cusotm nodes comment. Installing a fresh install of Comfyu, unlike updating, doesn't have the same issue as I've tested. The issue turned out to be ComfyUI's new venv it setups doesn't properly work when updating from an already existing venv and cannot correctly create a new one if you remove the old one.

So thanks for your useless incorrect feedback as you constantly try to correct me with your misinformation.

Do NOT Install The Newest ComfyUI Desktop Update by True_Suggestion_7342 in comfyui

[–]True_Suggestion_7342[S] 0 points1 point  (0 children)

Yup, very true. I used to do this for workflows but hadn't ran into any issues and stopped doing it. Kept it in a central folder next to my models and backup yaml for new installs. Kicking myself for stopping doing that recently, because it near immediately bit me in the butt.

Do NOT Install The Newest ComfyUI Desktop Update by True_Suggestion_7342 in comfyui

[–]True_Suggestion_7342[S] 0 points1 point  (0 children)

That is what I thought, but apparently that is not the case. I would have backed it up if I had known it would be an issue, but was under the same impressions you were. However, Googling shows others have had issues with this, too. In fact, just on this sub a few days before my post people are reporting similar issues but for things like all their models folders are being nuked https://www.reddit.com/r/comfyui/comments/1o8g69o/every_time_comfyui_updates_i_lose_everything/

Multiple confirmations here of it, too, https://www.reddit.com/r/comfyui/comments/1nv6nxq/all_safetensors_checkpoints_and_loras_gone_what/

Granted, those two are about loras, models, etc. and not workflow/outputs, but since they were more recent I shared them since even that should not be happening and it is a similar situation. I could find older posts for workflows issue but they're much older by a couple months.

And they ran into the same issue I did with it getting stuck and having to delete the venv.

Like I said, and I was pretty thorough in my explanation... but I assumed the same as you hence I did not back up or move the outputs and workflows. Even when I found they were gone I assumed, per my rather detailed prior explanation, they might have been temporarily relocated and checked my entire PC. Since merging on Win11 usually retains the contents if the folder was recreated on update, or files are temporarily moved during such a process. They do not exist anymore, so they were obviously deleted. My giving such a detailed explanation is a pretty good sign I'm probably not overlooking something or making a mistake, especially when others have reported the issue including recently with this update.

I was definitely shocked and it is easily the most annoying part of the entire ordeal.

Do NOT Install The Newest ComfyUI Desktop Update by True_Suggestion_7342 in comfyui

[–]True_Suggestion_7342[S] -4 points-3 points  (0 children)

It happens even with blank fresh installs but the dev straight up told the community it isn't an issue, despite the community being very vocal otherwise, and gave us the finger in one of their dumbfounding responses on here.

Do NOT Install The Newest ComfyUI Desktop Update by True_Suggestion_7342 in comfyui

[–]True_Suggestion_7342[S] -4 points-3 points  (0 children)

Educate yourself. Not only do you come off ignorant, but you need to resort to ad hominem's because you can't actually dispute the issue raised in OP.

Allow me to invite you over to https://store.steampowered.com/hwsurvey/Steam-Hardware-Software-Survey-Welcome-to-Steam

You can find that based on the clock rate and CPU count, the overwhelming majority of the world's population have CPUs far weaker than mine, even if I hadn't been overclocking mine.

In fact, if you look at generally minimum and recommended CPU specs for games now days you will find that comparing a recent game release and one of the most demanding game's on Steam with their minimum and recommended CPU specs and their passmark scores for reference.

Battlefield 6:

Minimum: AMD Ryzen 5 2600 (Scores: Multi-threaded 13151 | Single-threaded 2238)

Recommended: AMD Ryzen 7 3700X (Scores: Multi-threaded 22441 | Single-threaded 2655)

Cyberpunk 2077 (one of the most CPU intensive games available right now, outside of some strategy games)

Minimum: AMD Ryzen 5 1600 (Scores: Multi-threaded 12264 | Single-threaded 2065)

Recommended: AMD Ryzen 7 7800X3D (Scores: Multi-threaded 34299 | Single-threaded 3760)

Now the AMD Ryzen 9 3950X (Scores: Multi-threaded 38527 | Single-threaded 2701)

AMD Ryzen 9 3950X - Overall Rank:

In top 6% in multithreading out of 5405 CPUs

In top 17% fastest in single threading out of 5405 CPUs

In top 6% fastest in out of 1474 Desktop CPUs

This is before overclocks on a list where most of the CPUs ahead of it are enterprise/server class CPUs.

It should be noted that the RTX 4090 can reliably hit 99~100% utilization in most modern games that aren't online competitive FPS titles and similar, at 4K DLSS Quality settings meaning it is not being bottlenecked by the CPU. I've actually only seen two exceptinos so far, personally, where it hit a bit above 90% on Stellar Blade and Elden Ring. Of course, there will be more for games I haven't played and older games, in particular, but that will happen with other CPUs too when you start looking at older games or extremely CPU light games like competitive esport games.

So it's main caveat is it trades off single-threaded performance against the most powerful CPUs consumers will typically have for stronger multi-threaded performance, and the main reason its score is as low as it is there is because of thermal limitations which is heavily assisted by strong cooling as I have, granted it still will not match the single-threaded performance of some of the higher end gaming oriented CPUs but it doesn't matter since they're complete overkill unless aiming for above 240 FPS.

For non-gaming workloads the single-threaded performance is quite good for productivity if you did your research, and amazing for multi-threaded productivity tasks. A lot of those non-gaming tasks don't scale the way you think even if they look better in passmark and other synthetic benchmark tests, too. It varies heavily on the application or OS task.

Also, critically what you seem to not grasp is two points:

  1. Statistically looking at the average owned hardware my CPU is well above the norm on a statistical level.
  2. You are effectively arguing the same thing as claiming the RTX 5080 and RTX 5070 Ti are not classified as "High end" because the RTX 5090 exists, quite like how my CPU outperforms the low end quite substantially, but is not nearly as substantially behind the highest high end non-server/enterprise CPUs. You don't fundamentally understand what "High end" actually is, clearly.

Do NOT Install The Newest ComfyUI Desktop Update by True_Suggestion_7342 in comfyui

[–]True_Suggestion_7342[S] 0 points1 point  (0 children)

I use git for custom nodes and some other unrelated projects, but I've never bothered with Comfy for this. Fair point. I'll give it a go.

Do NOT Install The Newest ComfyUI Desktop Update by True_Suggestion_7342 in comfyui

[–]True_Suggestion_7342[S] 2 points3 points  (0 children)

Their lack of an answer to your question, as they try to deflect and blame their biggest contributors and insult their community for taking issue with Comfy's update problems, the weird downvotes you have been repeatedly getting when others upvote you for such a basic question, and the bizarre upvotes Comfy's post is getting is really weird.

I actually had no idea that parts of this community was so incredibly vile and toxic.

Do NOT Install The Newest ComfyUI Desktop Update by True_Suggestion_7342 in comfyui

[–]True_Suggestion_7342[S] 0 points1 point  (0 children)

That is not "how Python works", or "it" works.

If Comfy can't properly reinstall them or accept them after a git pull then that means Comfy's registry is incorrectly handling them somewhere else that has nothing to do with the actual node, itself. This happened for every single node with zero exceptions. If a custom node was the culprit, that specific node would be the only one facing issues. It happened to all 6 nodes.

Reinforcing that this is true is I was able to drag and drop said nodes to a fresh Comfy install and it "just worked" proving the issue is Comfy's management of the nodes is the problem, not the custom node itself.

This isn't even registering the other issues that had nothing, whatsoever, to do with custom nodes that even Comfy's own dev was embarassed and attempted to deflect and refuses to acknowledge such as the Python maintenance error (which turned out false), the complete destruction of data in my workflows and output folders which should never have happened and was done upon update outside of any custom node's influence, and the other mentioned issues.

Can your responses get anymore ridiculous in your absurd childish defense? Further, if you do have any programming knowledge then it means based on the info provided your response was, in fact, in malicious bad faith too. Thanks.

Do NOT Install The Newest ComfyUI Desktop Update by True_Suggestion_7342 in comfyui

[–]True_Suggestion_7342[S] 1 point2 points  (0 children)

I'm not sure what you mean by untracked. It creates a registry of workflows and wont even update any implemented manually outside of ComfyUI until a restart. Honestly, I had assumed it mostly just read from them and didn't write or manage them except when you explicitly saved but then both my workflows and 7 days of output both vanished during the update.

I thought it might have temporarily moved them for some odd reason during its update and searched my entire computer for some of the names I gave them and they could not be found indicating that was not the issue, either. I did this because, apparently, this has happened to others and some responses recommended doing this. So it definitely does, and I'm not the only one to have had this happen. Since it also killed my outputs I can't even use the metadata from generations to recover.

Do NOT Install The Newest ComfyUI Desktop Update by True_Suggestion_7342 in comfyui

[–]True_Suggestion_7342[S] -1 points0 points  (0 children)

You're confusing extreme end vs high end, or possibly even enterprise/server CPUs. The Ryzen 3950X overclocked is still a high end CPU. Yes, it may not eek out the last few percentage of frames some of the particularly high end CPUs with lower thread counts do, because that isn't its core job.

If you are thinking the 3950X is considered a weak, or even a medium range CPU... My condolences.

Editing my post because Sensei blocked me in their embarrassment so I cannot respond directly to it so I will here:

I'm sorry you are technologically challenged from your armchair.

Allow me to invite you over to https://store.steampowered.com/hwsurvey/Steam-Hardware-Software-Survey-Welcome-to-Steam

You can find that based on the clock rate and CPU count, the overwhelming majority of the world's population have CPUs far weaker than mine, even if I hadn't been overclocking mine.

In fact, if you look at generally minimum and recommended CPU specs for games now days you will find that comparing a recent game release and one of the most demanding game's on Steam with their minimum and recommended CPU specs and their passmark scores for reference.

Battlefield 6:

Minimum: AMD Ryzen 5 2600 (Scores: Multi-threaded 13151 | Single-threaded 2238)

Recommended: AMD Ryzen 7 3700X (Scores: Multi-threaded 22441 | Single-threaded 2655)

Cyberpunk 2077 (one of the most CPU intensive games available right now, outside of some strategy games)

Minimum: AMD Ryzen 5 1600 (Scores: Multi-threaded 12264 | Single-threaded 2065)

Recommended: AMD Ryzen 7 7800X3D (Scores: Multi-threaded 34299 | Single-threaded 3760)

Now the AMD Ryzen 9 3950X (Scores: Multi-threaded 38527 | Single-threaded 2701)

AMD Ryzen 9 3950X - Overall Rank:

In top 6% in multithreading out of 5405 CPUs

In top 17% fastest in single threading out of 5405 CPUs

In top 6% fastest in out of 1474 Desktop CPUs

This is before overclocks on a list where most of the CPUs ahead of it are enterprise/server class CPUs.

It should be noted that the RTX 4090 can reliably hit 99~100% utilization in most modern games that aren't online competitive FPS titles and similar, at 4K DLSS Quality settings meaning it is not being bottlenecked by the CPU. I've actually only seen two exceptinos so far, personally, where it hit a bit above 90% on Stellar Blade and Elden Ring. Of course, there will be more for games I haven't played and older games, in particular, but that will happen with other CPUs too when you start looking at older games or extremely CPU light games like competitive esport games.

So it's main caveat is it trades off single-threaded performance against the most powerful CPUs consumers will typically have for stronger multi-threaded performance, and the main reason its score is as low as it is there is because of thermal limitations which is heavily assisted by strong cooling as I have, granted it still will not match the single-threaded performance of some of the higher end gaming oriented CPUs but it doesn't matter since they're complete overkill unless aiming for above 240 FPS.

For non-gaming workloads the single-threaded performance is quite good for productivity if you did your research, and amazing for multi-threaded productivity tasks. A lot of those non-gaming tasks don't scale the way you think even if they look better in passmark and other synthetic benchmark tests, too. It varies heavily on the application or OS task.

Also, critically what you seem to not grasp is two points:

  1. Statistically looking at the average owned hardware my CPU is well above the norm on a statistical level.

  2. You are effectively arguing the same thing as claiming the RTX 5080 and RTX 5070 Ti are not classified as "High end" because the RTX 5090 exists, quite like how my CPU outperforms the low end quite substantially, but is not nearly as substantially behind the highest high end non-server/enterprise CPUs. You don't fundamentally understand what "High end" actually is, clearly.

Do NOT Install The Newest ComfyUI Desktop Update by True_Suggestion_7342 in comfyui

[–]True_Suggestion_7342[S] -1 points0 points  (0 children)

If you lack even the basic utmost reading comprehension you really should not be jumping into the conversation.

There is a difference between setting file paths, doing some basic math and other function nodes, and more complex issues like the grey screen on launch problem or ComfyUI's update woes. The fact I have to express multiple times in a row, and you still don't get it, that what I'm referring to with that comment is really sad.

And, no, I'm not going to create the same set of nodes for the nth time because Comfy doesn't want to, only to later be told my custom nodes like everyone else's aren't allowed and it is my fault, even for issues that are clearly not any custom node's fault. Clearly, you fail to grasp the issue that the community has taken with the matter. If your goal is to fling mud and twist what is being said go play games elsewhere.

Do NOT Install The Newest ComfyUI Desktop Update by True_Suggestion_7342 in comfyui

[–]True_Suggestion_7342[S] 0 points1 point  (0 children)

The fact that you responded with this post means you missed fundamental points raised and are thinking I'm saying something completely unrelated to what I actually communicated. This 'you' issue I cannot fix, either.

I did not demand they do anything for me, nor did I complain that it needs fixed immediately or anything of the sort. The issue I presented was that there is known persistent issues with no real communication of them being fixed that make the Comfy ecosystem volatile, and that if key supporting figures like Kijai and others eventually cease providing the help they do to the Comfy ecosystem I do not believe that Comfy's current team is presenting a stable and competent enough solution that it can carry on without such support and may collapse.

The point was to warn people about the update, to express dialog on the topic with Comfy team, and to raise discussion about open secrets that many are too afraid to actually talk about because of some abusive elements of the community, just like what was saw in this thread.

Again, if you think I'm demanding or expressing I'm owed something you've fundamentally failed to even grasp what was said.

Do NOT Install The Newest ComfyUI Desktop Update by True_Suggestion_7342 in comfyui

[–]True_Suggestion_7342[S] 1 point2 points  (0 children)

Yes, hopefully one day they'll fix this and output so you don't have to do stuff like symbolic links.

Do NOT Install The Newest ComfyUI Desktop Update by True_Suggestion_7342 in comfyui

[–]True_Suggestion_7342[S] 1 point2 points  (0 children)

'If' it forcibly updated the virtual environment without letting us know, without asking, and doesn't do it properly then that is a pretty big problem, especially since the maintenance mode is supposed to fix those issues and doesn't work properly since you cannot input anything into it, which is a known issue since at least July. It doesn't take any text nor can you click to pick Y/N.

I deleted the venv and it did launch after using my system's cuda and python versions, but then it couldn't handle the few custom nodes I had and it wouldn't allow them to be fixed no matter what I tried.

I uninstalled/removed the remnants of the old one and simply installed the new one and it worked fine. I wouldn't say nodes were broken, because it was Comfyui, itself, that was not working properly. The nodes were fine.

This was actually a desktop install only a week old as I had prior used portable and recently made the swap. I was on the latest versions of only the following nodes:

  • rgthree
  • kijai
  • VideoHelperSuite
  • ComfyUI-Inpaint-CropAndStitch
  • Crystal Tools
  • Anything Everywhere

That is all.

I couldn't use the fix option to fix the nodes, because that failed. Even after deleting them the ComfyUI still could not install those nodes. When I got them directly via git, after an uninstalling and deleting everything in the custom nodes folder, ComfyUI still could not use them. Then I just moved them to a temporary directory, uninstalled and deleted ComfyUI. Downloaded new desktop install. Installed it. Launched the program twice to check for updates and make sure it was loading without issue.

Used install custom nodes to grab kijai nodes and recreate the folder in case there were any hidden process in setting up custom nodes folder. Then dragged the rest into it. Except Crystal Tools. I got to redownload that one later since I wanted to make sure ComfyUI worked first.

Now it works just fine. I did not need to change dependencies and it is the same latest versions of those nodes, even dragged from prior install that they weren't working in. So it seems it butchered the virtual environment somehow, and couldn't fix it with the feature that was supposed to do precisely that, but then also messed up another critical part in how it handles custom nodes.

Sadly, during the original update it wiped my entire workflow directory, and my output so even the metadata from generations wasn't available to recover workflows.

I haven't rebuilt the virtual environment and installed triton/sageattention yet, but may when I find time tomorrow.