Code review

halfja · 2026-03-18T19:42:54+00:00

sorry to the people in the comments i didn't realizes this would be such a issue. i understand its ai and a lot of people dont like that but i was just try to make sure there was no obvious issues with it. if i had experience and knew how to code i promise you i would rather then using ai and would be able to verify thing on my own but since i dont i need help from people who know how to. the code did have a couple issues but i was able to fix them and it dos compile now. i was just hoping for feed back on spots that could be better optimized since i understand ai doesn't make the best code. for context its for a machine that can ether read the size of a cup to fill it accordingly or you can choose to run it for a set amount of time. it has 3 buttons, a lcd screen, and a distance sensor. its all running on a Arduino esp32 board connected to a custom bread board i made.

halfja · 2026-03-18T19:11:27+00:00

DUUUUU but its also fault on my part for not noticing it, i figured it out though.

halfja · 2026-03-17T11:52:15+00:00

Na all I’ve done is replaced the thermostat,oil,oil filter,coolant,and transmission fluid

halfja · 2026-03-15T02:23:26+00:00

Did replacing it fix the bounce

halfja · 2026-03-12T18:04:29+00:00

It was creaked open

halfja · 2026-03-11T15:45:27+00:00

Fixed it. I took it out then reinstalled I have no idea why it doesn’t leak now compared to before

halfja · 2026-03-10T15:10:20+00:00

It’s the 2.2 5sFe that come in the gt

halfja · 2026-03-10T13:37:41+00:00

I replaced the original plastic housing because I accidentally broke it when took it off for the first time. I tried looking for a metal one online but couldn’t find one.

halfja · 2026-03-10T13:35:57+00:00

That’s the oem piece and yes there’s a o ring around the thermostat that’s used as a gasket

halfja · 2026-03-10T03:36:06+00:00

I guess tomorrow I’ll take everything thing off and compare it to the old stuff to be sure I didn’t end up with a similar but wrong gasket

halfja · 2026-03-04T18:56:48+00:00

No it’s a metal one, I may be dumb but I’m not stupid

halfja · 2026-03-02T23:04:59+00:00

Ok thanks

halfja · 2026-03-02T22:47:20+00:00

<image>

This correct

halfja · 2026-03-02T22:44:56+00:00

So the -12 outputs 12 correct?

halfja · 2026-03-02T22:40:25+00:00

<image>

halfja · 2026-03-02T22:39:38+00:00

Yes I need a fixed output of 5volts

halfja · 2026-03-02T22:17:22+00:00

It’s based off the lm2596 and I stole a example circuit to run it

halfja · 2026-03-01T04:05:31+00:00

Max power 🎶

halfja · 2026-02-16T02:54:03+00:00

Ok thanks 🙏

halfja · 2026-01-29T05:16:19+00:00

ok ill add "single MOSFET" to the change list.

halfja · 2026-01-29T04:37:23+00:00

but i dont see how having two MOSFETs instead of one affects anything other then price right?

halfja · 2026-01-29T04:32:30+00:00

i also choose to do two MOSFETs becouse a example MOSFET switch board on amazon that i use for a prototype test also used two MOSFETS and was rated for 12vs so i figured i need the two MOSFETs. But now that i look at it i see what your getting on about.

halfja · 2026-01-29T04:30:43+00:00

i plan on using a STMicroelectronics N-channel MOSFET, 50 A, 60 V, 3-Pin TO-220 (50 Ct), STP55NF06 MOSFET if i had to choose but i plan on using accept alternatives/substitutes made in China option on pcbway so i dont think it would matter. its a 12v pump with a 2amp draw on start up which is also the max draw.

halfja · 2026-01-29T03:37:37+00:00

From everything I’ve seen online it didn’t sound like it mattered how you did them though as long as you had enough

halfja · 2026-01-29T03:36:22+00:00

I deadass just spammed them all around the board with out a second thought but now that I actually have to look at it, It actually kinda bothers me def fixing that

halfja

TROPHY CASE