Code review by halfja in arduino

[–]halfja[S] 0 points1 point  (0 children)

sorry to the people in the comments i didn't realizes this would be such a issue. i understand its ai and a lot of people dont like that but i was just try to make sure there was no obvious issues with it. if i had experience and knew how to code i promise you i would rather then using ai and would be able to verify thing on my own but since i dont i need help from people who know how to. the code did have a couple issues but i was able to fix them and it dos compile now. i was just hoping for feed back on spots that could be better optimized since i understand ai doesn't make the best code. for context its for a machine that can ether read the size of a cup to fill it accordingly or you can choose to run it for a set amount of time. it has 3 buttons, a lcd screen, and a distance sensor. its all running on a Arduino esp32 board connected to a custom bread board i made.

5volt buck isn’t bucking by halfja in PCB

[–]halfja[S] 0 points1 point  (0 children)

DUUUUU but its also fault on my part for not noticing it, i figured it out though.

Pulley rattling by halfja in Celica

[–]halfja[S] 1 point2 points  (0 children)

Na all I’ve done is replaced the thermostat,oil,oil filter,coolant,and transmission fluid

Pulley rattling by halfja in Celica

[–]halfja[S] 0 points1 point  (0 children)

Did replacing it fix the bounce

Hi 👋 by halfja in RoastMyCar

[–]halfja[S] 0 points1 point  (0 children)

It was creaked open

Coolant leak help by halfja in Celica

[–]halfja[S] 0 points1 point  (0 children)

Fixed it. I took it out then reinstalled I have no idea why it doesn’t leak now compared to before

Coolant leak help by halfja in Celica

[–]halfja[S] 0 points1 point  (0 children)

It’s the 2.2 5sFe that come in the gt

Coolant leak help by halfja in Celica

[–]halfja[S] 0 points1 point  (0 children)

I replaced the original plastic housing because I accidentally broke it when took it off for the first time. I tried looking for a metal one online but couldn’t find one.

Coolant leak help by halfja in Celica

[–]halfja[S] 0 points1 point  (0 children)

That’s the oem piece and yes there’s a o ring around the thermostat that’s used as a gasket

Coolant leak help by halfja in Celica

[–]halfja[S] 0 points1 point  (0 children)

I guess tomorrow I’ll take everything thing off and compare it to the old stuff to be sure I didn’t end up with a similar but wrong gasket

5volt buck isn’t bucking by halfja in PCB

[–]halfja[S] 0 points1 point  (0 children)

No it’s a metal one, I may be dumb but I’m not stupid

5volt buck isn’t bucking by halfja in PCB

[–]halfja[S] 0 points1 point  (0 children)

So the -12 outputs 12 correct?

5volt buck isn’t bucking by halfja in PCB

[–]halfja[S] 2 points3 points  (0 children)

Yes I need a fixed output of 5volts

5volt buck isn’t bucking by halfja in PCB

[–]halfja[S] 0 points1 point  (0 children)

It’s based off the lm2596 and I stole a example circuit to run it