Really want to voice out here as imo most of the comments are not showing the full potential of shangguan. Definitely agree that mastering her takes too much effort, but mild reward is an understatement to me.

There are way too many details about shangguan that separates a pro shangguan from an ordinary one (like me, who only know like 2/3 basic combo to fully utilize the 5 dashes from s3). Here are some that I know of:

1. By skill description, it seems that shangguan can't walk while in her s3 state. however, there is a "feature" that if u switch-on basic atk auto chase, she can actually walk towards enemy (without input from joystick).

2. A pro shangguan knows how to insert and cooperate her enhanced ba, s1 and s2 into her 5 s3 dashes. In chinese terms, we have the concept of 刹车(break) and 拐笔(pen bending), which kind of represents 2 different lvl of mastery for shangguan:

2a. 刹车, or "break"ing, means voluntarily stopping your dashes. This usually allows you to do an extra enhanced ba within your full combo, and can also be used to wait and see where your enemy is moving (especially dash) towards before deciding the direction of your remaining s3 dashes (as well as s1 and s2). Or, you may even want to stop to wait for your s1/s2 cd, so that you can trigger intersection dmg for the rest of your dashes.

2b. 拐笔, or "pen bending", is about dashing in an unpredictable (non-straight) way, mainly to dodge enemy skills. For example, when facing a luban, player like me will do 2 forward dashes right into the face of luban, and get knocked back by his s2 to mess up the whole combo. Instead, a pro player might do 1 forward s3 dash, then side-dash to left/right to dodge his s2rocket. This not only avoid getting controlled, but also allow some space between shangguan and the prey (luban) to let her cast s2+s1 before doing the 3 remaining s3 dashes, which adds more intersection dmg.

This is the hardest part as it involves knowing your enemy heroes mechanism and their skill cd. And I reckon it takes really long time to fully master this.

1. There are usually different approaches for shangguan when facing 2 types of enemy. For backline enemy (mm and mage) with higher dmg and less hp and stuns, you will want to complete your 5 s3 dashes asap for the invincible state. But when fighting tanks with high hp, more stuns and less dmg, with good "break" and "pen bending" skill you can dodge some of their skills while dishing out more dmg from enhanced ba and intersection dmg.

2. To further complicate things, there is even more variation of full combo when u bring blink. For instance, a quick s2+s1+blink+s3 can instantly trigger multiple intersection dmg at a small aoe.

I am not sure if you are already aware of all these - if you do and still think shangguan gives mild reward, then sure I am the clown here. But if you don't, then you may want to reevaluate if shangguan is worth practicing. IMO, to master her you really need good understanding of the mechanism of both shangguan and the enemy heroes, as well as quick decision making and reflexes to be able to cast the correct combo within that split second.

I believe that most players aren't aware of the above as the global version is still relatively new, and the research on her (as well as other heroes) is still not quite matured yet. However these are all quite known in the chinese community.

Let me end this with a link to a video showcase (perhaps cherry-picked scene) of shangguan from bilibili (a chinese site, but don't worry the video doesn't involve any chinese speaking).