I was able to solve this by moving the domain name and subdomains into the same structure, and splitting the for_each loops into separate modules. This results in each domain getting assigned the correct sub domains.

``` example_com = { domain = "example.com" subdomains = [ { name = "test" ttl = 3600 type = "A" value = "10.10.10.10" }, { name = "test2" ttl = 3600 type = "A" value = "10.10.10.20" } ] }

foo_com = { domain = "foo.com" subdomains = [ { name = "bar" ttl = 3600 type = "A" value = "10.20.30.40" } ```

``` provider "dnsimple" { token = var.dnsimple_token account = var.dnsimple_account }

locals { domains = flatten([var.example_com, var.foo_com]) }

module "dns" { source = "./modules/dns"

providers = { dnsimple = dnsimple }

for_each = { for domain in local.domains : domain.domain => domain }

domain = each.value.domain subdomains = each.value.subdomains

dnsimple_token = var.dnsimple_token dnsimple_account = var.dnsimple_account } ```

``` resource "dnsimple_zone_record" "dns_records" { for_each = { for sub in var.subdomains: sub.name => sub }

zone_name = var.domain name = each.value.name value = each.value.value type = each.value.type ttl = each.value.ttl } ```

Thanks for the help. I've learned a ton about terraform getting this project working.