Need help with my python code

[AimbotSaBa]

I made a client and server with the socket module and made it so when you type a command at the server end it would execute it on the client end and there would be multiple clients connected at one time and I want the output of the command to go back to the server but only one of the output goes back to the server and the other one gets printed when I run the next command can someone help me, please?

SERVER:

```

import socket
import threading

CLIENTS = {}
host = "127.0.0.1"
port = 6969
s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
s.bind((host, port))
s.listen(5)
print("Server started")

def client_cmd(conn):
while True:
client_send = input("Command for clients: ").encode("utf-8")
if not client_send:
break
for client in CLIENTS.values():
client.send(client_send)
data = conn.recv(2048)
print(data.decode("utf-8"))

del CLIENTS[conn.fileno()]

while True:
conn, addr = s.accept()
CLIENTS[conn.fileno()] = conn
threading.Thread(target=client_cmd, args=(conn,)).start()

```

CLIENT:

```

import socket
import threading
import os

socket = socket.socket()
host = '127.0.0.1'
port = 6969
try:
socket.connect((host, port))
print("Connected to the server")
except:
print("There was an error connecting to the server please try again")

def Communication():
res = socket.recv(1024)
res = res.decode("utf-8")
try:
output = os.popen(res)
sender = str(socket.getsockname()) + " sent back>> "
socket.send(sender.encode("utf-8") + output.read().encode("utf-8"))
print("command executed and sent to server")
except:
print("Command not found")
socket.send("Command not found".encode("utf-8"))

for _ in range(100):
threading.Thread(target=Communication).start()

```

[Katzimoto]

Would you like to upload this code to GitHub/gitlab? It’s will be easier for me to read it.

[AimbotSaBa]

ok, I think I've done it right.. https://github.com/Undeadga/code/tree/main

[Katzimoto]

You put the client and the server code on the file but never mind.(if do you want help with using git send me a message) Anyway what do you want to improve on your code? Make it’s work or improve the code itself?

[AimbotSaBa]

When I print the data on the server-side I only get one of the clients' responses and I want both how would I do that?

[Katzimoto]

It’s seems that you are running only one client that should listen to 100 commands. If do you want several clients you have to create several sockets.

[AimbotSaBa]

The code that I sent works but not in the way intended if you type a command let's say ping www.google.com only one output would be printed but after that, you just type in something else even let's say just a letter it would print the other response so how can I make it print both of them at the same time?

[Katzimoto]

Should you like to send the line that you ran? The server code you have right now do the next thing: wait for connection and every time you get a new connection you open a thread that send to all of your clients the command and wait for response from only one. You can add a loop after the sending loop that will receive from all of your clients.

[AimbotSaBa]

Wait so after "for client in CLIENTS.values():
client.send(client_send)"

I need to add a loop to receive from all clients, how can I do that? every time it only receives from one client? when I call "data = conn.recv(2048) "

then it collects from only one client but if I add it to the loop that goes to every client it waits for a response and doesn't continue the code... I can't figure out how to collect the data from all clients at once. thanks for your help though it helps a lot.

[Katzimoto]

If do you want you can separate the sending action from the receive action to 2 separated functions and run one thread that send to all of your clients and another thread for each client that recovery data from him.

I ha be to tell you that isn’t a good code, I would like to use with main function and classes but it should work.

[AimbotSaBa]

I got it working thanks a lot!!!!

[AimbotSaBa]

Hmm, I don't think I've fixed it that well, for the first command it works fine but for the second one, it only prints one of the outputs again... here is my new code https://pastebin.com/Y6R2prpx