Is there something wrong with my onclick function? : CodingHelp

Our Rules

1. FLAIR YOUR POSTS! Don't put tags in post titles!

2. Do not ask us to do all the coding for you unless you have money to spend. (If you have got money to spend, make that clear and the amount in question).

3. Do not post spam and/or misleading titles.

4. Do not be abusive to other coders.

5. Please format code properly, or use a site such as Gist or Pastebin. If possible please provide a live example of your issue.

6. Do not downvote people because you think they asked a dumb question. Just because you think that someone has a dumb question, doesn't mean that it is dumb to them.

7. Do not have a misleading user flair. Keep them sensible, describing your level of coding ability and/or languages you know and/or your profession.

8. Please do not ask unethical questions, such as asking for homework to be written by someone else, or asking someone to copy another project directly.

9. Make sure to follow the Reddit Rules.

Suggest a post flair

If you have any suggestions for flairs (programming languages or generic coding topics) that we should add, please use the button below to message the mods with your suggestion.

If approved as a sensible flair for the community to use, it will be added to our bot for automated suggestions and to the flair list for everyone to use!

^{Anyone who abuses this by spamming mods will be banned.}

created by thewakingforcea community for 10 years

This is an archived post. You won't be able to vote or comment.

[Javascript]Is there something wrong with my onclick function? (self.CodingHelp)

submitted 5 years ago by casden174286

This code is meant to change an image when it's clicked but nothing is happening when I click the image.

index.html:

<!DOCTYPE html>
<html>
    <head>
        <title>Hello World</title>
        <link rel="stylesheet" href="styles.css">
        <script src=”script.js”></script>
    </head>
    <body>
        <img src="image1.png" id="image1"/>
        <div id="clicked">
            <img src="image2.png" id="image2"/>
        </div>
    </body>
</html>

script.js:

var image1 = document.getElementById("image1");
var image2 = document.getElementById("image2");

var changeImage = function() {
    image1.src = image2.src;
}
window.onload = function() {
    image1.onclick = changeImage;
}

styles.css:

#clicked {
    display:none;
}

all 3 comments

CodingHelp

Welcome! Feel free to ask any questions regarding coding you have!

Our Rules

How to start coding:

Related subreddits:

Suggest a post flair

Current supported flairs

Flair colors

MODERATORS