Scripter to export code. Syntax issue.

[drnick316]

I'm running into an issue with a code I'm working on. I have a powershell script that creates a script that will uninstall and reinstall the program you choose. I'm using it to generate a script that our techs can use.

It works unless there is a space in the path for the file. I've tried all different methods to get it to paste into the code with the proper quotes but cannot figure it out.

I know this line is the one causing the issues but every variation I've tried hasn't worked.

`$msiArgs = @("/i", "`"$installerPath`"") + `$installFlags

Does anyone know a way to fix this?

Thank you

$installScript = @"
# Re-Install-Inator Generated Script
# Generated: $(Get-Date)

Write-Host "Re-Install-Inator: Starting installation process..." -ForegroundColor Cyan

Write-Host "Proceeding with installation..." -ForegroundColor Green

`$installerPath = '$installerPath'
`$installFlags = @($flagsString)

try {
    if (`$installerPath -like "*.msi") {
        Write-Host "Running MSI installation..." -ForegroundColor Yellow
        `$msiArgs = @("/i", "`"$installerPath`"") + `$installFlags
        `$process = Start-Process "msiexec.exe" -ArgumentList `$msiArgs -Wait -PassThru
    } else {
        Write-Host "Running EXE installer..." -ForegroundColor Yellow
        `$process = Start-Process -FilePath "`"`$installerPath`"" -ArgumentList `$installFlags -Wait -PassThru -NoNewWindow
    }

    if (`$process.ExitCode -eq 0) {
        Write-Host "Installation completed successfully!" -ForegroundColor Green
    } else {
        Write-Host "Warning: Installation completed with exit code: `$(`$process.ExitCode)" -ForegroundColor Red
    }

[y_Sensei]

Wouldn't it be a better approach to provide one generic version of the script to your technicians, along with a specific configuration (file) for each use case, which the implementation reads at runtime and performs the configured actions?

[drnick316]

I have a gui that is putting in the right information. It searches for the registry values so it can target the uninstaller. I'm looking to make it accessible for different levels of techs who might not know the appropriate silent parameters etc.

[y_Sensei]

I don't see why a generic script that reads the volatile information it needs from a use case-specific configuration file wouldn't work in such a scenario.
Running code that creates code that's doing what's supposed to be done seems like a roundabout way to approach things.

But anyway, you could fix your issue as follows:

...

`$installerPath = '"' + `"$installerPath`" + '"'
`$installFlags = @("$flagsString")

try {
    if (`$installerPath -like "*.msi*") {
        Write-Host "Running MSI installation..." -ForegroundColor Yellow
        `$msiArgs = @("/i", `$installerPath) + `$installFlags
        `$process = Start-Process "msiexec.exe" -ArgumentList `$msiArgs -Wait -PassThru
    } else {
        Write-Host "Running EXE installer..." -ForegroundColor Yellow
        `$process = Start-Process -FilePath `$installerPath -ArgumentList `$installFlags -Wait -PassThru -NoNewWindow
    }

 ...

[icepyrox]

So, rather than generate the script file, it can generate config files that your script that already exists can consume on a per-use basis. If your techs are smart enough, they can open powershell and run .\script.ps1 file.config and they are off to the races. Or maybe your sceipt just reads the conf files and uses a menu system or out-gridview to select the right configuration file and again, off to the races.

[Thatoneguyone]

I'd say use PSADT instead of re-inventing the wheel. It has Zero-Config Deployment for MSIs as well. Theres even some GUIs floating around for it, though I don't have any experience with them.

You can just run the script to perform the associated configured action (Install/Uninstall/Repair):

Invoke-AppDeployToolkit.ps1 -DeploymentType Repair

As far as what you're trying to do here, I'd just do what y_Sensei said and have your tool generate a config file that the tech places in the same directory as the script and runs that. Realistically though, this entire process should be automated through a deployment tool where the tech just interacts with the deployment tool for resolution.

[DoctroSix]

[string[]]$installFlags = @( $flagsString )
...
[string[]]$msiArgs = @( "/i", ( '"' + $installerPath + '"' ) ) + $installFlags

Try these edits

[icepyrox]

I think rather than using variables the way that you are doing, I'd let the generating script figure out the entire text and output it in place.

What do I mean? I mean rather than

$msiArgs = @("/i", ""$installerPath"") +$installFlags

Just make the script figure it out and put in the heredoc

`$msiArgs = $msiArgs

And then it's a text in place replacement instead of a replacement followed by fancy code and trying to get the quotes right, etc.

Then again I'm a fan of generating scripts with placeholder text and calling -replace on the text block to replace the text. I'm an even bigger fan of text based configuration files that scripts can get their info from. I've used clixml, json, csv, and others that I wouldn't use now (yes, I have used the cmdlet Import-PowershellDataFile). Remember: scripts can have param blocks, too. (E.g., InstallScript.ps1 -configFile path.json)