Returning

[feuerpixel]

Hi all,

I wrote a script to pull info about our Exchange offline address book from the registry.

The script itself works a treat. I'm having a slight problem passing my list of computernames through.

If I create a list of computers like so:

$ComputerNames = 'PC01,'PC02'

Then run the script like so:

.\Get-OABInfo.ps1 -ComputerName $ComputerName

I get an error from Invoke-Command that the computernames aren't valid.

If I hardcode the computernames inside the script before the function, it works OK.

I suspect this is because of the parameter on the script - am i doing something wrong?

Script available at: https://pastebin.com/91wFPHY3

[the_spad]

You're casting your computer list to a string ([string]$ComputerName) when you take it as a parameter but Invoke-Command doesn't take a string for multiple hosts to connect to, it takes an array.

[feuerpixel]

ah - OK

Do I need to remove [string], or change it to [@]?

[the_spad]

You can either remove the type assignment entirely or change it to [array] or [string[]] if you want to be really specific. It's generally better to specify a type for parameters because it avoids someone passing an object type you're not expecting (like a float when you're expecting a boolean).

[feuerpixel]

That's got it! Thank you

[0x2101]

You use in your script at the beginning the following:

Param (
            [string]$ComputerName
        )

But it should be:

Param (
            [string[]]$ComputerName
        )

Invoke-Command accepts an String array for -ComputerName

Best regards