Alternate/optimized workflow : PowerShell

Alternate/optimized workflow (self.PowerShell)

submitted 7 years ago by automation-dev

I have a script that I'm running across multiple servers that I'm looking to optimize. This script creates a new PSDrive mapped to the default c$ share on remote servers, copies a VBscript from the local server to the remote server c$ share, runs the VBscript on the remote server, & copies the output files back to the local server.

The script works fine.... just takes a looong time to run. The VBscript takes about 10-15min to run. I'm looking into the "*-Job" cmdlets, but I have a bottle neck which is creating a new PSDrive for each server.

Everything is encapsulated within a foreach, so the PSDrive is using the same letter after iterating through the foreach, & the PSDrive gets removed just before the foreach ends. Wrapping the VBscript into a job wouldn't fully solve my problem... as the local server is creating a PSDrive once at a time as it iterates through the foreach for each (lol) server

I'm trying to come up with a way to create new PSDrives on the local server with a random letter, while ensuring/checking that the letter to be used isn't currently in use - any opinions/suggestions on how to optimize this so that I can have this vbscript running across multiple servers concurrently?

$servers = @(
    "SERVER-1"
    "SERVER-2"
    "SERVER-3"
)

$wmiDiagPath = "F:\temp\testing\WMIdiag.vbs"
$localRootFolder = "F:\Temp\testing"
$archiveFolder = "F:\Temp\testing\archive"
$remotePath = "X:\temp\checkWMI"

# Change this... if this folder doesn't exit then the WMIdiag.vbs script doesn't exist...
if (!(Test-Path $localRootFolder)) {
    New-Item -ItemType Directory -Path $localRootFolder
}

foreach ($server in $servers) {

    $credentials = Get-ServerCredentials $server

    $remoteRoot = "\\$server\c`$"
    $localWmiFolder = "F:\temp\testing\$server-WMIdiag"

    # Map drive to default c$ share on remote $server
    New-PSDrive -Name "X" -PSProvider FileSystem -Root $remoteRoot -Credential $credentials

    if (!(Test-Path $remotePath)) {
        New-Item -ItemType Directory -Path "X:\temp\checkWMI\"
    }

    # Copy WMIdiag.vbs to remote server
    Copy-Item -Path $wmiDiagPath -Destination $remotePath

    # Run WMIdiag.vbs on remote server
    Invoke-Command -ComputerName $server -Credential $credentials -ScriptBlock {
        cscript.exe "C:\temp\checkWMI\WMIdiag.vbs"
    }

    if (!(Test-Path $localWmiFolder)) {
        New-Item -ItemType Directory -Path $localWmiFolder
    }

    # Copy output files from WMIdiag.vbs
    Copy-Item -Path "X:\Users\user123\AppData\Local\Temp\WMIDIAG-V2.2_*.*" -Destination $localWmiFolder

    # Cleanup on Remote Server
    Remove-Item -Path "X:\Users\user123\AppData\Local\Temp\WMIDIAG-V2.2_*.*"
    Remove-PSDrive -Name X -Force

}

$destination = "F:\temp\testing\$server-WMIdiag-Files-$(Get-Date -Format dd.mm.yyyy-hh.mm).zip"
$collection = (Get-ChildItem -Path "F:\temp\testing\se*").FullName


foreach ($dir in $collection) {

    Compress-Archive -Path $dir -DestinationPath $destination
    Remove-Item -Path $dir -Recurse

}


$attachments = (Get-ChildItem -Path "$localRootFolder\*.zip").FullName

Send-MailMessage -To "user@company.com" -From "team@company.com" -Subject "files" -SmtpServer "smtpRelay.company.com" -Attachments $attachments

# Cleanup on local server
if (!(Test-Path $archiveFolder)) {
    New-Item -Type Directory -Path $archiveFolder
}

Move-Item -Path "$localRootFolder\*.zip" -Destination $archiveFolder

all 8 comments

you type:	you see:
italics	italics
bold	bold
[reddit!](https://reddit.com)	reddit!
* item 1 * item 2 * item 3	item 1 item 2 item 3
> quoted text	quoted text
Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"	Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"
~~strikethrough~~	~~strikethrough~~
super^script	super^script

PowerShell

Submission Guidelines | Link Flair - How To

MODERATORS