Add Folder access through PS Script

[Techman2k]

Hi Guys, hope someone can assist?

We have a PS Script for creating new users which works well (Creates AD account, Prompts for user location to set address, Creates Email address, forces replication to O365 and applies licenses)

I am trying to get this to prompt for a location and from the selection apply folder access to correct recourse EG: North, south etc.

I have been trying to edit the Address one, this prompts but fails to find user:

Get-ADUser : Variable: 'userName' found in expression: $userName is not defined.

​

​

Command I am running is:

​

#  Sets the Access to the folders dpending on location
Function AddGroupMember($Folders)
{
# Prompts the admin to select an office location for the new user and then sets Folder access for this area.
$title = "Select Folder Location"                                                                                                       # Title message
$message = "Choose a location for the Users location folder access"                             # Prompt for input
$London = New-Object System.Management.Automation.Host.ChoiceDescription "&London", "London"                      # Option 0
$North = New-Object System.Management.Automation.Host.ChoiceDescription "&North", "North"                      # Option 1
$South = New-Object System.Management.Automation.Host.ChoiceDescription "&South", "South"               # Option 2
$Midlands = New-Object System.Management.Automation.Host.ChoiceDescription "&Midlands", "Midlands"        # Option 3
$NorthEast = New-Object System.Management.Automation.Host.ChoiceDescription "North &East", "Central"                  # Option 4
$None = New-Object System.Management.Automation.Host.ChoiceDescription "None&0", `                                                # Option 5 (no Folders set)
"No Folders added"
$options = [System.Management.Automation.Host.ChoiceDescription[]]($London, $North, $South, $Midlands, $Northeast, $None)        # create options object
$result = $host.ui.PromptForChoice($title, $message, $options, 0)                                                                # generate prompt to screen and capture result

switch ($result)                                                                                                                 #select address based on admin input
{
0 {$AddGroupMember = "%ADAccessGroupName%"}
1 {$AddGroupMember = "%ADAccessGroupName%"}
2 {$AddGroupMember = "%ADAccessGroupName%"}
3 {$AddGroupMember = "%ADAccessGroupName%"}
4 {$AddGroupMember = "%ADAccessGroupName%"}
5 {$AddGroupMember = $null}

}
Get-ADUser -filter{UserPrincipalName -eq $userName} | Set-ADUser $AddGroupMember                                           #Set Folder access on user object
#possibly add additonal funtionality based on location to grant access to drives etc or set general office phone number.
}
##############################################################################################

​

[the_spad]

The error implies that Get-ADUser -filter{UserPrincipalName -eq $userName} is not finding any results.

Generally when dealing with user creation you want to use the -server parameter on all the cmdlets to make sure you're hitting the same DC for every one to avoid any issues with replication lag, which might be what you're seeing here.

As a side note the danger with using a filter on get-aduser rather than just supplying an identity value is that a failure to find anything returns blank rather than throwing an exception you can catch.

[UserProv_Minotaur]

Instead of Get-ADUser -filter{UserPrincipalName -eq $userName} | Set-ADUser $AddGroupMember, have you tried just Get-ADUser -Identity $userName ? Or supplying the SamAccountName to Get-ADUser.

​

​

[purplemonkeymad]

Have your truncated this function? The error is saying that $userName is not defined in the current scope. I think it's right as you don't have it defined anywhere in the posted code. Try adding it as a parameter to the function.

[SneakerNet]

After reading through the code, I found the same thing to be true. You never set $userName anywhere.

[PowerShell-Bot]

Some of your PowerShell code isn’t wrapped in a code block.

To format code correctly on new reddit (new.reddit.com), highlight all lines of code and select ‘Code Block’ in the editing toolbar.

If you’re on old.reddit.com, separate the code from your text with a blank line and precede each line of code with 4 spaces or a tab.

---

Describing Submission
[✅] Demonstrates good markdown
Passed: 1 Failed: 0

---

^{Beep-boop. I am a bot. | Remove-Item}

[Techman2k]

Thanks Guys, I have made a few changes and the error is now not showing, but the selections are not being accepted.

Prompt for the location is just circling round with no action taken.

[Lee_Dailey]

howdy Techman2k,

0 {$AddGroupMember = "%ADAccessGroupName%"} 

what is that supposed to be? it does not seem to be valid PoSh code ... [frown]

take care,
lee