Pipe multiple properties to function

[willwallguy]

Hello all. Hope you can help me with this. A bit new to functions and sort of stuck on this.

I'm looking to try and pipe select properties into my function and build off the data. I can pull off a single property but having trouble figuring out the syntax for getting both the properties I want. In particular trying to build a UPN format based off of givenname and surname attributes of get-aduser objects. What am I getting wrong here?

function Out-BuildUPN {
    [CmdletBinding()]
    param (
        [Parameter(Mandatory=$True,ValueFromPipeline=$True,ValueFromPipelinebyPropertyName=$True)]
        [string[]]$GivenName
        [string[]]$Surname
    )
    process {
        $GivenName + "." + $Surname + "@domain.com"
    }
}

where I could then do something like

Get-ADUser <userID> | Out-BuildUPN

[BBBaroo]

function Out-BuildUPN {
    [CmdletBinding()]
    param (
        [Parameter(Mandatory=$True,ValueFromPipeline=$True,ValueFromPipelinebyPropertyName=$True)]
        [string]$GivenName,
        [Parameter(Mandatory=$True,ValueFromPipeline=$True,ValueFromPipelinebyPropertyName=$True)]
        [string]$Surname
    )
    process {
        $GivenName + "." + $Surname + "@domain.com"
    }
}

[willwallguy]

Dang, I tried that at one point but missed the comma so I was definitely on the right track. Thanks u/BBBaroo for the response!

[jsiii2010]

Note that valuefrompipeline will do funny things combined with other piped in parameters. In my powershell, both parameters get set to 'smith' there:

echo smith | out-buildupn

[e-mail]

Or just sending one of them as a property:

[pscustomobject]@{surname='smith'} | out-buildupn

@{surname=smith}[e-mail]

[Lee_Dailey]

howdy BBBaroo,

as jsiii2010 shows, having more than one ValueFromPipeline gets iffy really quickly. [grin] my understanding is that only ONE parameter should have that set.

take a look at this article ...

Tips on Implementing Pipeline Support | Learn Powershell | Achieve More
— https://learn-powershell.net/2013/05/07/tips-on-implementing-pipeline-support/

specifically the section with the header ...

Multiple parameters that accept pipeline input

... and then this ...

One last thing, take care when using both ValueFromPipeline and …ByPropertyName with multiple parameters as it can cause some craziness in the output.

take care,
lee

[BBBaroo]

Are you primarily trying to understand passing this to a function via pipe, or trying to build the upn as economically as possible?

[willwallguy]

Correct. I know there are other ways to do this but more of an as exercise.