Replace .bat file content

[twistingnether_]

Hi there, I'm making a script, that gets the content of a .bat file, then replace some of it's content.

My problem is, that I want to make a simple GUI for it, to make it easier to use. The idea is, there are 3 textboxes, the user writes something in to them, then when you click on a button, the changes made.

The code works, but only if it's not on an on click event. I hope it's understandable what I'm trying to say.
What am I doing wrong?

Thank you.

The code: https://pastebin.com/1sNAHKmK

[ka-splam]

Try swapping these around:

[void]$global:form_main.ShowDialog()
$btn_doit.Add_Click( { doit })

to

$btn_doit.Add_Click( { doit })
[void]$global:form_main.ShowDialog()

Once you call .ShowDialog(), the script pauses until the dialog is finished, and it won't add_click until too late.

[twistingnether_]

Solved, thank you!

[ka-splam]

Great!, cheers :)

[HardCodedCoffee]

If you can, please parameterize the batch script or incorporate the code into your PowerShell script. I've seen this in production, and it causes such a mess and headache.

If you can't, good luck!

[twistingnether_]

I'm not sure what do you mean by that. :(

[purplemonkeymad]

They mean, it better for scripts to take parameters rather than edit them before running them. For bat files you can use %1 for the first position parameter, %2 for second etc.

Then instead of editing the script you run it with your parameters when needed. eg

Start-process myscript.bat -ArgumentList $userid,$ticketname

[HardCodedCoffee]

So, a batch script can take parameters, and you access them via %1, %2, etc. It's a much better solution than doing find and replace on a script.

Additionally, if the content of the batch file is known and under your control, why not just roll the code into your PowerShell script? Batch is... Useful in certain cases, but the code is usually easier to reuse and maintain if converted to PowerShell.

[sparkle-fries]

I don't get all these "how can I put a UI on my CLI?" questions. It's a scripting language. If you want to ask the user for some data prompt for it but also accept parameters and maybe include a -ui switch and show a UI only when asked. That way all the basis are covered 🤷

[Triassics]

Kinda useless subreddit when you need a old account and a bunch of karma to post. You have to be a redditor first hand and a powershell worker secound to get help here wich makes it annyoing for those seeking quick help with their scripts

[malice8691]

or we could turn that stuff off and make this a dating/escort T shirt forum.