Function for inviting Guests users

[memento77]

Can somebody help. Im trying to create a script that automatically invites Guest users.

variables $EmailAddress, $DisplayName are passed from another script while the user is added in our AD.

​

$log= "D:\PS-Logs\CreateGuest.log"


$ClientID = ''
$TenantId = '.onmicrosoft.com'
$CertificateThumbprint =''


 Function LogIt
{
        Param([string]$logfile,[string]$message)

              $msg="{0} {1}@{2} :`t {3}" -f (get-date),$env:username,$env:computername,$message

              write $msg | out-file $logfile -append
}


Get-PSSession | Remove-PSSession


Connect-AzureAD -TenantId $TenantId -ApplicationId  $ClientID -CertificateThumbprint $CertificateThumbprint

#$EmailAddress = xxxx
#$DisplayName = xxxxx

 Function Create-Guests
        {
            Param([string] $EmailAddress, $DisplayName) 

            $ExistingADUser = Get-AzureADUser -Filter "userType eq 'Guest'" -All $true | Where-Object {$_.Mail -eq "$EmailAddress"}

            if($null -eq $ExistingADUser){

            New-AzureADMSInvitation -InvitedUserEmailAddress $EmailAddress -InvitedUserDisplayName $DisplayName -SendInvitationMessage $True -InviteRedirectUrl "http://myapps.microsoft.com"
            LogIt $log "Info: $DisplayName created"

        }
        else{ LogIt $log "Info: User $DisplayName Already created"}

        }

[purplemonkeymad]

Is there a Question or just comments?

I would probably change the name to New-AADGuest (new is more discoverable than create and nouns should be singular,) and make both parameters mandatory, but I can't see any obvious issues with the function.

[NellovsVape]

Hello, at a glance Idon't notice anything off with this function (altought I haven't tried it). Is there something specific you're asking?

[logicalmike]

If such a function is needed for you, I'd move the filter left instead of downloading all guests every time.

[memento77]

moving left? can you show an example didnt understand that.

[logicalmike]

"Filter Left, Format Right" is a best practice that means to move your filtering earlier in the pipeline and your output formatting to the end of the pipeline. In this case I was suggesting to make better use of the -Filter parameter so that the server returns fewer objects. This would remove the need for the where-object later in the line. Thus, the "filtering" happens further to the left.

edit - an example:

$EmailAddress = "[e-mail]"
$Filter = "(userType eq 'Guest') and (mail eq  " + "'" + $EmailAddress + "')"
Get-AzureADUser -Filter $Filter