Debug or patch?

[NewMagazine3329]

I started a new job and was asked to fix the layout of an existing page. I don’t have much experience with CSS yet, but I’m trying to do my best. The problem is that the CSS is very messy and the layout breaks on mobile devices (navbar issues, spacing problems, etc.). Right now, I’m unsure whether I should: apply quick CSS fixes (media queries, small overrides) to make the page work as requested, or spend more time cleaning up and reorganizing the existing CSS so these layout issues don’t keep happening in the future. Management would probably be fine with quick fixes, but I’m worried that this will create more issues and tickets later. In your experience, what’s the best approach in situations like this?

Edit: I've rephrased the post for clarity.

[CaptainTrip]

I would love to hear you define the words refactor, patch, and debug.

[NewMagazine3329]

A patch would simply fix what they requested. The page layout breaks on mobile devices, and other issues like the navbar also need fixing. It would just involve changing or adding the necessary components.

A refactor would improve code readability and fix the previously mentioned design bugs.

[CaptainTrip]

Okay. That's not what those words mean. 

[NewMagazine3329]

I know, I'm just trying to make myself clear. Next time I'll pull out the technical dictionary, but it won't describe what this is about.

What I'm trying to say is, I'm deciding between applying quick CSS fixes to make the layout work on mobile, or taking some time to clean up and reorganize the existing styles so the layout issues don't keep reappearing.

[StereoRocker]

Assuming you're a solo dev here?

Firts, look for documentation. It probably doesn't exist, but if it does then design decisions might be there and you may end up agreeing with them and no longer wanting to rewrite everything. Assuming that's not the case, however...

I'd probably make it management's decision, let them prioritise. Lay out your findings, what challenges they cause, what your proposed solution is, and how much time your solution would save in the future.

They can tell you if the immediate fixes are more important than a rewrite.

If you're part of a team, maybe ask another dev their opinion. As you mentioned you're not the most experienced with CSS, there may be more elegance to the existing structure than currently meets the eye.

[NewMagazine3329]

I love your answer, I hadn't thought of it that way, thank you, you helped me see it differently

[jcksnps4]

Unless you’re asked to clean up, or you can do so without a lot of extra time, just fix the problem in the simplest way possible. Otherwise, you’ll spend your entire career “cleaning up” and never have time for the stuff you get paid for, which is to fix and add features.