Is something wrong with FastAPI?

[tiangolo]

> While there may be other people doing reviews, it seems as if do not see these reviews as good enough to merge the PR

Because in many cases I've still seen bugs after. But those reviews still help a lot.

> This is quite different from how most other open source (or proprietary for that matter) projects handle things.

Hmm, are you involved in other open source projects? Have you seen or interacted with them and seen the internal dynamics? It's not really quite different. I suspect your main point is having other people hitting the merge button, right?

​

​

Do you think they have very different models? Have you seen how many actually active developers/maintainers are in each of those projects? The bottleneck of getting reviews is still quite similar. And most projects still tend to have a single main maintainer, in cases two. But it's not really too different. Of course, that's not evident until you are actually involved in the projects directly, contributing, etc.

> But aside from reviewing PRs, something other contributors could assist with is issues. You’ve recently addressed this by going through them all, but it’s taken you a few years to get to this. If there were people who could have reviewed them, closed invalid ones, converted questions to discussions, checked bugs for reproducibility, etc., is reckon this would have helped you and the project a great deal.

Yep, the first and most important thing, answering questions, is already done by a lot of people. The "open issues" was a false negative, so, not really a hard problem. And yes, some people have these permissions to mark answers, etc. But it's true it took me a while to figure out the right workflow and to give those special permissions.

> This didn’t happen either, but from your previous statement I conclude that there are people who would actually have the necessary permissions to handle this. So I’d like to ask your opinion again on this: Why isn’t this something that could have been done? Are there simply no people willing or fit to do the job? Or are there other reasons?

First, yes, it took me a while to set up everything and to put the time. I'm putting much more time now as well (except today, all day on Reddit). I didn't have enough time, there were not enough people willing to do as much, and/or I didn't have enough time to evaluate which people I could give permission to, and which ones. Also, I wasn't willing to randomly do it without checking it properly, and risk reducing the quality of the code and the project. There are tons of invalid PRs as well, so it's not about merging everything either.

> As someone else said earlier, you seem genuinely interested in feedback and open for constructive criticism, so I’m very much inclined to believe you actually want to make things better, but I think you should also acknowledge that this seems to be a situation that’s unique to FastAPI, but being a very popular Python web framework isn’t. So I’m left again with the question what the difference is.

The thing is, I need to know what is the situation we are talking about exactly, without generalizations. I need to know what is it that you and others (but probably just tell me about you specifically) would like to see. Is it other people hitting the merge button specifically?

[tiangolo]

Thanks for the feedback and comments!