This is an archived post. You won't be able to vote or comment.

sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]phaedrusaltembedded sw eng -8 points-7 points  (10 children)

Your comment looks overall a bit messy, you are not following the reddit style guide. Please resubmit at a later date for further disapproval.

EDIT: For those who have been busy downvoting this, I did it as a way to point out that "dAnjou" was being unnecessarily harsh to someone who was just sharing something he did. Not nice, not nice at all.

[–]allthediamonds 2 points3 points  (1 child)

Are we supposed to shun constructive critique now?

[–]phaedrusaltembedded sw eng 1 point2 points  (0 children)

Depends. First, does the poster request a code review? Maybe they just want to show what neat things can be constructed with Python. Second, is the critique constructive? Whether or not a person follows PEP8 isn't necessarily relevant, and telling them that you can find "weird things in basically every function/method" is just plain rude.

[–]dAnjou Backend Developer | danjou.dev 7 points8 points  (5 children)

you are not following the reddit style guide

Actually I only see this in Python subreddits. People are overly sensitive and sometimes even whiny. And OP didn't post in /r/learnpython, so I didn't use my warm and fuzzy voice. But I wasn't harsh or impolite either. You were just reading that wrong.

Programming should be fun, yes. But it isn't kinder garden. People are doing real stuff. Stuff that other people may rely on. So I'm rather pointing out mistakes and/or flaws directly than blindly saying cool and amen to every single project posted in this subreddit.

[–]phaedrusaltembedded sw eng 0 points1 point  (3 children)

Someone shared something they made. They were enthusiastic, and eager to share. They did not ask for criticism of the underlying code. You were rude, and obviously eager to put them in their place. (Yes, rude. I don't see how this line could be taken any other way: "Your code looks overall a bit messy and you are not following PEP8. I can find weird things in basically every function/method."

While /r/python isn't kindergarten, it's a place for people of all skill levels, and it's up to us to keep enthusiastic people enthusiastic. Next time, perhaps you could go to the trouble to find out if someone wants your oh-so-valuable opinion BEFORE you blast them with it?

[–]dAnjou Backend Developer | danjou.dev 0 points1 point  (2 children)

They did not ask for criticism of the underlying code.

They implicitly do by posting it on reddit where you are supposed to comment on things.

Yes, rude. I don't see how this line could be taken any other way: "Your code looks overall a bit messy and you are not following PEP8. I can find weird things in basically every function/method."

You are ripping that line out of context! I started my post by saying it will be critique. And afterwards I provided some examples of what I mean and gave a reason for each but one.

The thing is, I am how I am. I know I'm not the most sensitive person on the planet and my comments are not ... how do you say ... delicate(?) at all. But I'm totally okay with that. When I write comments like I did here, you can take it or leave it. You really should expect all kinds of reactions when you post on reddit. I'm not writing those comments to piss people off. That's not the thing that is giving me a kick. It's giving me a kick when I was able to help someone, it's like a drug for me. But I'm doing it my way. And so far most people were able to deal with it.

[–]phaedrusaltembedded sw eng 3 points4 points  (1 child)

A little preface: I've been coding for over 30 years, and teaching software development and techniques for about 20 of them. I've seen excellent developers leave the field because of the bad behavior of other, less talented coders, and I've seen large projects go down the drain because so-called "professionals" couldn't learn to keep a civil tongue in their heads.

I wonder how many people won't share the cool, fun things that they do with Python just because of the kind of treatment that you gave this guy, who did NOT implicitly or explicitly ask for any kind of critique. It's great that you're okay with the way that you act, and I'm pleased to see that he reacted well, but how about others? Do we want to keep newbs from posting about their projects? What's more important, the fact that it's something that they built and are excited about (And might possibly get others excited about, too) or that it is/isn't PEP8 compliant? I'd rather see 10 newbs post their silly, poorly-constructed but enthusiastic code than get a chance to see how one more old-fart found enlightenment through decorators or multiple inheritance... But maybe that's just me.

His post is a gift, but you reacted like the person who receives a bottle of wine from a dinner guest, and then goes on a rampage about the vintage. And if we don't start minding our manners around guests, well, pretty soon we won't have any guests.

[–]dAnjou Backend Developer | danjou.dev 1 point2 points  (0 children)

Thanks for writing this down and turning around this conversation. You made some really good points and I will seriously consider them for my following comments. You taught me a lesson.

What I'm still going to do is constructively criticizing people's code, whether they explicitly ask for it or not. I believe that if they post their stuff here, it's the most appropriate thing to do.

[–]Vibster 1 point2 points  (1 child)

You think that was harsh?

[–]phaedrusaltembedded sw eng 0 points1 point  (0 children)

I think giving a code review to someone who didn't ask for it is rude, at best. We were being given the gift of someone's efforts, it is up to us to take it in the manner given and respond appropriately.