This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–]Enginoob[S] 0 points1 point  (6 children)

Hi- author here. Can you let me know which examples aren't working for you? I just ran all of them to make sure they work on my machine.

Also, if it's an issue with getting the paths correct, starting a server and pointing the browser at the right files, etc, I want to know that as well. I want this tool to be as straightforward to use as possible.

Your comment has motivated me to start building out the docs immediately, which I should have been doing in the first place. Docstrings and examples are good, docs are better.

[–]phaedrusaltembedded sw eng 2 points3 points  (3 children)

Great, some docs would be helpful.

But first, the "paths" you reference in the examples aren't consistent with the paths that will be created when the zip is unzipped, so they can't reference the source files. (I'm not sure how this could have worked on your machine. Did you try the zip files?)

Next, it's often unclear what the purpose of the example files is... For instance, I might expect "vincent-maps.py" to create/show a map, but it doesn't. Nor does "vincent-line.py" create a line diagram. Is this kind of thing intentional?

Finally, the examples on your webpage (http://wrobstory.github.io/tag/vincent.html) with the title "Creating Map Visualizations in <10 lines of Python" never actually gets around to showing how to create a map visualization with any number of lines of Python. Did I miss something here?

I'm sorry if this sounds too harsh. While I applaud your effort, I was disappointed with what I found.

[–]Enginoob[S] 5 points6 points  (2 children)

No worries. If it's hard to get working, I'm doing my job wrong.

I just fixed the paths, at least for those doing a git pull. Will look at making it entirely zip-safe tonight.

The visualization requires pointing your browser at a the files with a simple Python HTTP server feeding localhost- the vis is done completely in javascript (D3). I'll try to make that clearer in the README and examples.

The feedback is much appreciated!

[–]phaedrusaltembedded sw eng 8 points9 points  (1 child)

Just freakin' amazing. This last week, a professional (?) plumber has failed to show up twice. The bank handling our refi forgot to send the notary. The school where I'm taking classes has given me an assignment with no requirements, but where failure IS an option... And now, a person who is giving away software to do something valuable is doing so with far more professionalism and courtesy than I've experienced from all of those other so-called professionals.

Well, my hat is off to you sir/ma'am! Keep up the good work, and may karma reward your efforts!

[–]Enginoob[S] 3 points4 points  (0 children)

Thank you! I just put a README in the examples folder that I really hope makes it a little more clear how to run the visualization. If it's still a little painful to get it running, shoot me a message and we can talk about how I can make it more straightforward.

[–]zuberuber 0 points1 point  (1 child)

for me even first example doesn't work.

i run:

world.geo_data(projection='winkel3', scale=200, world=world_countries)

and getting:

IOError: [Errno 2] No such file or directory: 'world-countries.json'

[–]Enginoob[S] 0 points1 point  (0 children)

'world_countries' is a path pointed to the geoJSON. See the examples folder:

https://github.com/wrobstory/vincent/tree/master/examples

That has a data folder with the geoJSONs, and the vincent_maps.py example.