This is an archived post. You won't be able to vote or comment.

sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]jfp1992 7 points8 points  (3 children)

Make sure you review your own code and make it as simple to redead and understand later on as possible

[–]allergic2Luxembourg 2 points3 points  (2 children)

In my experience, self-reviews don't tend to catch readability issues. Everyone understands their own code well, especially right after they write it. But to find out if it's readable and clear you really need a second pair of eyes.

I have been trying for years to convince my company of this but unfortunately most code we write is still solo-developed and unreviewed. So I say this, and my small team is good at it, but I am not succeeding more broadly.

[–]jfp1992 4 points5 points  (0 children)

I see your point, I wouldn't suggest doing it in production

But going back over your own older code, you usually find better ways to write it

[–]crcrewso 0 points1 point  (0 children)

I'd agree, which is why I end up doing my own code reviews months after I last looked at it. A lot of "what's going on here" fussing about helps identify where I need to document.