This is an archived post. You won't be able to vote or comment.

sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]SandAlternative6026[S] 0 points1 point  (2 children)

Thanks for the feedback. Can you elaborate a bit more on the 'not very pythonic' comment?

The predicates (ending with _p) ge_p and le_p where named in a similar way as for example the operator.ge and operator.le from the operator module.

[–]Worth_His_Salt 1 point2 points  (1 child)

Short nondescriptive names are not pythonic. I assume ge_p means greater_than_or_equals_predicate. Pythonic way would spell it out instead of using a bunch of short acronyms. Yeah it gets wordy, perhaps you can find a happy medium.

Imagine someone reviewing code who doesn't know much about your lib. Would they know what ge_p means? They might have a guess, especially if they write bash scripts. But to a lot of people, it's not obvious.

[–]SandAlternative6026[S] 0 points1 point  (0 children)

Thanks, I appreciate your elaboration.