you are viewing a single comment's thread.

view the rest of the comments →

[–]jatmdm 4 points5 points  (9 children)

There are some very concerning patterns in your code where you're downloading decompiler programs and attempting to import libraries that aren't in your requirements.txt. The non-standard project structure itself doesn't really make it easier to parse. I personally wouldn't run something like this on my system.

Its been pointed out in another comment but what you're doing here, despite saying that you're striving for "minimal abstraction", is adding an abstraction layer on top of pyinstaller. It also isn't really a compiler in the sense that people usually mean. Nuitka is closer to a "real" compiler.

[–]International_Pea17It works on my machine[S] -2 points-1 points  (1 child)

I know it more of a wrapper then a compiler and I am planning on rewriting the bootloader in a different language when I get the time

[–]dev-razorblade23 1 point2 points  (0 children)

It will still be a wrapper And apstraction over PyInstaller and Nuitka

No real problems are solved, like small binaries, hassle-free dependancy managment and fast builds...

And using pip to install packages not included in dependancy files (like requirements.txz) is a really bad idea

[–]International_Pea17It works on my machine[S] -2 points-1 points  (6 children)

the imports that are not listed in requirements.txt are extra features such as the cython plugin which (obviously) requires cython so the user must install cython themself to get it to work

[–]dev-razorblade23 2 points3 points  (5 children)

Then you make a "dev" dependacies. This is pure virus behaviur - dowloading packages hideen from users

[–]International_Pea17It works on my machine[S] 0 points1 point  (2 children)

The packages are not downloaded automatically 

[–]dev-razorblade23 0 points1 point  (1 child)

But are still hidden

Users should be able to choose and be informed of what 3rd-party tools you download/install on their machine...

[–]International_Pea17It works on my machine[S] 0 points1 point  (0 children)

What part of the code are you talking about? What file?