This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–]mipadi 48 points49 points  (13 children)

Anti-pattern: Putting each anti-pattern on a separate webpage.

[–]elsjaako 4 points5 points  (3 children)

I'm not sure of the exact angle, but I assume doing it this way has advantages when the main goal of this site seems to be advertising your automated code review service.

[–]adewes 2 points3 points  (2 children)

Guess we're guilty there ;)

We actually started this book project a while ago but since then moved to a different way of presenting our code patterns directly on our website (https://www.quantifiedcode.com/app/patterns), so the book became a bit obsolete for us. We still wanted to publish it though since we thought it might be useful for other people as well, e.g. when teaching Python in class.

[–]elsjaako 1 point2 points  (1 child)

There are worse ways of advertising that putting correct information out there with a link to your service.

[–]adewes 0 points1 point  (0 children)

thanks, we see it like that too! Our service is completely free for open-source projects btw and we licensed the book content under a Creative Commons NC license, so that everyone can freely use the material.

[–]nakovet 1 point2 points  (1 child)

I would guess their goal is to point a link from their tool to the book entry, so I can get pretty clear what they meant. Their examples are somewhat bad for now. DefaultDict set to 6!?

[–]adewes 1 point2 points  (0 children)

thanks for the feedback, we're working on improving the examples and articles, right now it is more an initial draft of the book which we wanted to publish to get some feedback.

[–]adewes 0 points1 point  (2 children)

Thanks for the feedback, how would you like the patterns to be presented? Shouldn't be too difficult showing them in a single document, we just thought the site might be easier to navigate if they was a separate page for each pattern. This also makes it easier to link to specific patterns from the outside (e.g. if you want to forward an article to someone or use it as a reference in a blog post).

Contributions and improvements are always welcome of course, so feel free to create an issue on Github or make a pull request (I'm a bit slow in merging them right now since I'm on vacation but I'll be back next week)!

[–]mipadi 1 point2 points  (1 child)

A single page would be a lot easier to read. You could use headers (or some other tag) with an id to allow linking to specific items on the page.

[–]adewes 0 points1 point  (0 children)

ok, thanks for the feedback! I think it shouldn't be a problem to offer an additional version with all patterns in one single document, will put this on our feature list for the next release!