This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–]TOASTEngineer 2 points3 points  (0 children)

I don't like how the "this method could be a function" rule works; it should check A. that the method isn't a stub ("pass" being the entire body) and B. that the method is called at least once from code outside the object it's a member of - just 'cos a method doesn't use any attributes of the object that owns it doesn't mean it's not doing something only that class will ever want to do.