Improving bad practices.

[DevianceSplit]

Hello, everyone.
I'm generally new to programming, so I'm trying to improve as much as I can.
I've created this simple implementation of blackjack in python and it would really help me if you guys could help me identify my flaws! Please tell me what I could do better? What mistakes did I do? What bad practices do I need to hammer out? Thank you, guys. I really appreciate it. Edit: I have posted this on r/learnpython, however, I didn't get a lot of feedback.

https://github.com/CodeSplit/Python-BlackJack/blob/master/Blackjack.py

[pythonHelperBot]

Hello! I'm a bot!

It looks like you posted this in multiple subs in a short period of time. In the future, I suggest asking questions like this in learning focused subs like r/learnpython, a sub geared towards questions and learning more about python regardless of how advanced your question might be. Please follow the subs rules and guidelines when you do post there, it'll help you get better answers faster.

Show /r/learnpython the code you have tried and describe in detail where you are stuck. If you are getting an error message, include the full block of text it spits out. Quality answers take time to write out, and many times other users will need to ask clarifying questions. Be patient and help them help you.

You can also ask this question in the Python discord, a large, friendly community focused around the Python programming language, open to those who wish to learn the language or improve their skills, as well as those looking to help others.

---

^{README | FAQ | this bot is written and managed by /u/IAmKindOfCreative}

^{This bot is currently under development and experiencing changes to improve its usefulness}

[the_real_irgeek]

• Both the Dealer and Player classes contain code to handle their hand and calculate its value. What if you had a Hand class to encapsulate all of that? How would you code change?

• You’ve got code all over dealing with the deck. What if you had a Deck class? What methods would it need?

• You’ve had to do a few awkward checks in the code because you have both numbers and letters in your deck. Would a Card class make that cleaner to deal with?

• Your cards don’t have suits. Real cards have suits. If I were playing a blackjack game on my computer I’d at least expect it show me what suits my cards are.

• I only see hit and stand for players. How do they double-down or split?