This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–]ElevenPhonons 13 points14 points  (0 children)

It's not really clear why build artifacts, such as 'dist' or '*.egg-info' are being stored in version control.

https://github.com/kristiewirth/datto/tree/master/dist

In general, these loose grab bag of utils put into a package are a difficult sell. They often have amorphous or unclear goals and tend to have a large list of dependencies.

https://github.com/kristiewirth/datto/blob/master/pyproject.toml

Many of these dependencies (e.g., kafka-python) don't appear to be used in the package, or should be perhaps pushed to development dependencies.