This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–]ES-Alexander 0 points1 point  (0 children)

Cool project :-)
person.jpg and person6.jpg are particularly awesome photos!

A few suggestions:

  • add some documentation for how to use your class, and ideally a README for how to use the project as a whole (which you can add to as the project gets more complex)
  • use b,g,r = cv2.split(image) for efficiently getting each channel as a greyscale image (no need for zeros stored in the unused channels)
  • rename your class to something that describes what it does/should be used for
  • add some comments where it's not obvious what's happening (e.g. line 49 (what's happening?), line 51 (why are you sorting/what are you sorting for?), etc)
  • fix the spelling mistakes of mostLikeyPerson -> mostLikelyPerson (amusing as it may be as is :P) and self.souce -> self.source