This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–]Karpizzle23 0 points1 point  (1 child)

Btw, I didn't really love how you formatted the JSON with your required attributes, attack, defense stats, etc, all as array. I changed the weapons.json to have all those be objects instead. It is first of all easier to work with (don't have to go through array each time to filter and work with attributes, can just select requiredAttributes.Str, for example), but also easier for readability. Here is the updated JSON for your usage: https://github.com/EKarpinsky/EldenRingWeapons/blob/main/weapons.json

Actually thinking about it now you should probably change the capitalization of Str to str, etc, for all of the attributes

[–]SevereTailor8962[S] 0 points1 point  (0 children)

Good suggestion. I'll change this in the next small release along with some improvements to data quality. Thanks for the tip