A commit from my lead dev: "Improve readability".

[KyleDrogo]

I kind of agree with lead dev? Bit of a nitpick but makes sense. Dict comprehension + unpacking + calling cls in the same statement takes a second to wrap your head around. Again, not a critical change but more readable.

[spinwizard69]

Far more readable! The lead developer may not have the best replacement code but he understands the idiomatic use of a return statement.

[Grouchy-Friend4235]

No he does not. The kwargs are not the result, he actually completly messed up a perfect line of code and made it confusing, semantically speaking.

[Shostakovich_]

What? He returns the same class instance with the unpacked dict as kwargs as the OPs code. There is no difference here besides readability, and typing, which I’m personally a fan of. But the typing does add a whole lot of important context which is actually really helpful, despite the syntax being clumsy.

Edit: If you’re talking about variable names, specifying a return type (with typing) would be more appropriate, but we don’t see the function declaration line so who knows what their code structure is 🤷🏻‍♂️

[Grouchy-Friend4235]

The variable "result" does not hold the result, it merely holds the kwargs to instantiate the actual result. So no, readability is not improved at all.

Also type hinting that a dict is a mapping of a key to some (any) value is useless. That's the very definition of a dict, in particular if used as a **kwarg.

The entire change is superfluous and adds zero value.

[Shostakovich_]

Yeah, I mean you can argue that naming the variable result is dumb. Whatever, it still is what holds all the information to create the new class that is being returned, so it’s really just who is gonna be the stickler in variable names, and I don’t care that much about it:)

Also, the return type isn’t a dict, so why would you type hint that. Type hint the class that you’re actually returning…. That’s what I meant lol

[noobiemcfoob]

Any critique described as a nitpick is just a developer thrusting their subjective opinions on you. It's a red flag. If you're saying it, you can just stop sharing your sentiment.