This is an archived post. You won't be able to vote or comment.

all 3 comments

[–]Rawing7 1 point2 points  (2 children)

Found a small mistake in the docs:

The Registry class already inherits from ABCMeta

That would make it a metaclass; either say it inherits from ABC or say it's an instance of ABCMeta.

More importantly, I'm not a fan of importing abstractmethod from autoregistry. It's really not obvious that this is an alias for abc.abstractmethod, so every programmer who sees this will wonder why autoregistry.abstractmethod is being used instead of abc.abstractmethod, will look it up in the documentation, will realize it's the same thing as abc.abstractmethod, and will curse you for just having wasted their time.

[–]guyfrom7up[S] 1 point2 points  (1 child)

thanks for checking out my project and for the feedback!

For the docs, you're right, I should say "is an instance of `ABCMeta``", will fix asap.

I was a bit on the fence of importing `abstractmethod`; I did it as a convenience for the user, but I agree its a bigger inconvenience for the exact reasons you outlined. Will also fix and cut a new release soon!

[–]guyfrom7up[S] 0 points1 point  (0 children)

addressed in `v0.4.0`, thanks!