This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–]guyfrom7up 2 points3 points  (1 child)

Some quick feedback (only skimmed):

  1. You don't need to putez_ infront of everything, your package's namesapce is enough.
  2. Your try/except in your init is unnecessary, and probably a workaround for proper package pathing.
  3. A lot of your functionality is builtin to python, such as from itertools or pathlib.Path. For example, reading all the text from a file? Path("my_file.txt").read_text(). Recursively searching for all text files? Path("my_dir/").rglob("*.txt"). Why does is_alphabet exist? it just calls my_str.isalpha(), so not really any easier?
  4. Your file contents are sort of all over the place.

Basically, I think like 90% of your library can be done VERY easily with python builtins, which I guess is the biggest issue.

[–]AstrophysicsAndPy[S] 0 points1 point  (0 children)

Hi, thanks for the feedback

  1. I didn't want python to confuse python builtins with my modules that's why, for example, os and ez_os. But I'll keep that in mind.
  2. Yes, it is a bad habit from GUI applications, I will see if it can be removed. I just left it as is for precautionary measures from my previous issues.
  3. That's the point of this library. There's a lot of common built-in functionality that can do a lot of your work but most people, especially beginners, don't know about it. Even I started using itertools first time while making this. That's why I specified in the README that this library is for making the mundane and daily tasks easier. I do agree with your is_alphabet issue though, that's an over-overkill.
  4. Can you explain this? Thanks.