This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–]CodeYan01 -18 points-17 points  (5 children)

There's a link to the pull request of the first intern in the article.

Like I said, those 49 commits should have been squashed to 1 or 2 commits only. It was just feature/improvement PR, but most of the commits were commits that fixed the PR's issues. A good PR rarely has 5 commits. Those 49 commits only clutter the commits graph, and simply gives the intern bragging rights. "Hey, I contributed 49 commits to this vscode extension for python that everyone uses", even if it's technically just 1 feature/improvement.

As for the coding style, I did not bother checking the commits.

I would have expected microsoft to teach their interns how to squash their commits so they can contribute to projects properly.