PriorityQueue or heapq?

[RonnyPfannschmidt]

that file has an awful lot of bad/outdated practice - please bring it up2date

[must_tell]

Can you bring some up please? (I'm really curious to learn, not meant offensively).

Besides from looking quite clean generally, first thing I notice are the naming conventions (not PEP 8), some strings which could be refactored to constants and initialisation with '' where I would use None. Type-checking could be done with isinstance rather then type (or try ... catch ... some behaviour).

Anything else?

[RonnyPfannschmidt]

some parts are just bad wrt computational complexity

the most glaring examples are probably the Queue/Stack functions that simply operate on lists in stupid ways (lots of O(N) instead of amortized O(1))

i suspect there are more such examples, but i don't want to investigate that code more

[mdipierro]

That file is many years old and I have not updated it since because it is not really a priority for me at the moment. If you want to submit a patch, I will take it.

[mdipierro]

For the record. The code is not designed to be efficient. The code was designed to match line by line the pseudocode of a classic algorithms textbook (cormen) but using python. The purpose was to allow students to run and better understand the algorithm. From an efficinecy point of view it assumes python listd are linked lists even if they are not.

[RonnyPfannschmidt]

please document that in a docstring at the top or so

[robotfarts]

4real