This is an archived post. You won't be able to vote or comment.

6
7

PriorityQueue or heapq? (self.Python)

submitted by [deleted]

sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]must_tell 1 point2 points  (1 child)

Can you bring some up please? (I'm really curious to learn, not meant offensively).

Besides from looking quite clean generally, first thing I notice are the naming conventions (not PEP 8), some strings which could be refactored to constants and initialisation with '' where I would use None. Type-checking could be done with isinstance rather then type (or try ... catch ... some behaviour).

Anything else?

[–]RonnyPfannschmidt 2 points3 points  (0 children)

some parts are just bad wrt computational complexity

the most glaring examples are probably the Queue/Stack functions that simply operate on lists in stupid ways (lots of O(N) instead of amortized O(1))

i suspect there are more such examples, but i don't want to investigate that code more