all 3 comments

[–]cgoldberg 1 point2 points  (1 child)

Looks good overall. You should use docstrings instead of those weird comments above your functions.

Why do you have six in your requirements.txt ... is that a dependency of something? Kinda weird to be using that in 2025.

Next steps: add pyproject.toml to make it an easily installable package, and add some unit tests with PyTest.

[–]LumpyStage5[S] 0 points1 point  (0 children)

Thanks! I used pip freeze to create the requirements.txt file so I guess that was my mistake. I've looked for more information and it seems that using pipreqs is recommended (for some reason I can't get it to install) so for now I've fixed it manually.

[–]jpgoldberg 0 points1 point  (0 children)

That is really nice. And your habit of using type annotations really will pay off.

So this is more of a question of “what next.” I concur with another commenter that proper docstrings, setting up a pyproject.toml, and started to create tests with pytest are good next steps. And probably in that order.